Polish the XML bookmarks examples

- Use Qt 5 connect syntax.
- Streamline code, remove unused members.
- Add a context menu for copying and opening the URLs.
- Add const to XML code.
- In the XML code, show the use of QStringLiteral in static inline
  functions to create strings versus QLatin1String in comparison
  overloads to avoid allocating strings from const char * literals.

Change-Id: Ib5e62ca188e271ffe01996dff3c9ea8e0b60739a
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>

1 files changed, 16 insertions, 12 deletions

diff --git a/examples/xml/saxbookmarks/xbelhandler.cpp b/examples/xml/saxbookmarks/xbelhandler.cpp
index 03b16c81f1..7e2a9db3c2 100644
--- a/examples/xml/saxbookmarks/xbelhandler.cpp
+++ b/examples/xml/saxbookmarks/xbelhandler.cpp
@@ -52,6 +52,10 @@
 
 #include "xbelhandler.h"
 
+static inline QString versionAttribute() { return QStringLiteral("version"); }
+static inline QString hrefAttribute() { return QStringLiteral("href"); }
+static inline QString foldedAttribute() { return QStringLiteral("folded"); }
+
 XbelHandler::XbelHandler(QTreeWidget *treeWidget)
     : treeWidget(treeWidget)
 {
@@ -72,32 +76,32 @@ bool XbelHandler::startElement(const QString & /* namespaceURI */,
                                const QString &qName,
                                const QXmlAttributes &attributes)
 {
-    if (!metXbelTag && qName != "xbel") {
+    if (!metXbelTag && qName != QLatin1String("xbel")) {
         errorStr = QObject::tr("The file is not an XBEL file.");
         return false;
     }
 
-    if (qName == "xbel") {
-        QString version = attributes.value("version");
-        if (!version.isEmpty() && version != "1.0") {
+    if (qName == QLatin1String("xbel")) {
+        QString version = attributes.value(versionAttribute());
+        if (!version.isEmpty() && version != QLatin1String("1.0")) {
             errorStr = QObject::tr("The file is not an XBEL version 1.0 file.");
             return false;
         }
         metXbelTag = true;
-    } else if (qName == "folder") {
+    } else if (qName == QLatin1String("folder")) {
         item = createChildItem(qName);
         item->setFlags(item->flags() | Qt::ItemIsEditable);
         item->setIcon(0, folderIcon);
         item->setText(0, QObject::tr("Folder"));
-        bool folded = (attributes.value("folded") != "no");
+        bool folded = (attributes.value(foldedAttribute()) != QLatin1String("no"));
         treeWidget->setItemExpanded(item, !folded);
-    } else if (qName == "bookmark") {
+    } else if (qName == QLatin1String("bookmark")) {
         item = createChildItem(qName);
         item->setFlags(item->flags() | Qt::ItemIsEditable);
         item->setIcon(0, bookmarkIcon);
         item->setText(0, QObject::tr("Unknown title"));
-        item->setText(1, attributes.value("href"));
-    } else if (qName == "separator") {
+        item->setText(1, attributes.value(hrefAttribute()));
+    } else if (qName == QLatin1String("separator")) {
         item = createChildItem(qName);
         item->setFlags(item->flags() & ~Qt::ItemIsSelectable);
         item->setText(0, QString(30, 0xB7));
@@ -111,11 +115,11 @@ bool XbelHandler::endElement(const QString & /* namespaceURI */,
                              const QString & /* localName */,
                              const QString &qName)
 {
-    if (qName == "title") {
+    if (qName == QLatin1String("title")) {
         if (item)
             item->setText(0, currentText);
-    } else if (qName == "folder" || qName == "bookmark"
-               || qName == "separator") {
+    } else if (qName == QLatin1String("folder") || qName == QLatin1String("bookmark")
+               || qName == QLatin1String("separator")) {
         item = item->parent();
     }
     return true;