summaryrefslogtreecommitdiffstats
path: root/mkspecs/common/msvc-version.conf
diff options
context:
space:
mode:
authorFriedemann Kleint <Friedemann.Kleint@qt.io>2018-08-22 14:29:56 +0200
committerFriedemann Kleint <Friedemann.Kleint@qt.io>2018-08-24 12:00:31 +0000
commit96c202e981346b9159fe9652676753d14a9dfaf4 (patch)
tree6a1360411a1b17bf107e7a530d36287236b2956e /mkspecs/common/msvc-version.conf
parent9dd9c6cae4b37d3bd14127f60d20e08a2f6b2808 (diff)
Refactor tst_QFiledialog::clearLineEdit()
The test had some shortcomings: - Flakyness due to not waiting for the file dialog list to be populated. - It assumed that the hardcoded directory name ____aaaa... always would show first in the list. This may not be true on Windows, where names like .designer show above. - On failure, the test directory would leak. This manifested in failures like: FAIL! : tst_QFiledialog::clearLineEdit() '(fd.directory().absolutePath() != QDir::home().absolutePath())' returned FALSE. () To fix this, use QTemporaryDir and introduce predicates that can be used to check whether the dialog has been populated and the right file/directory is selected by pressing cursor down. Use the temporary directory as not to pollute the home directory. Change-Id: Ic504b91325993dcd6099c99e125e7ed8ff1d7672 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: David Faure <david.faure@kdab.com>
Diffstat (limited to 'mkspecs/common/msvc-version.conf')
0 files changed, 0 insertions, 0 deletions