diff options
author | Antonio Larrosa <alarrosa@suse.com> | 2018-02-16 13:18:42 +0100 |
---|---|---|
committer | Laszlo Agocs <laszlo.agocs@qt.io> | 2018-02-21 17:03:58 +0000 |
commit | fa091640134b3ff99a9eb92df8286d15203122bf (patch) | |
tree | 55b27779ea342c71430d34b4d62cc0effd09247d /mkspecs/win32-clang-g++ | |
parent | 22d3eeebb0a011a61104de2eb635a3ecf26b58e2 (diff) |
opengl: Bail if cached shader fails to load
QOpenGLProgramBinaryCache::setProgramBinary() should check
GL_LINK_STATUS after glProgramBinary(), but doesn't.
In practice, this means that SDDM is a white screen, and KDE is just
a gray task bar.
So far, Qt tries to check this using its internal ::link() function.
But in case the cached binary fails to load, Qt currently attempts to
link the inexistent program, resulting in a zero-length, fixed
pipeline shader.
Checking this already in ::setProgramBinary() makes the call to
::link() superfluous, so we remove that as well.
Done-with: Max Staudt <mstaudt@suse.com>
Done-with: Michal Srb <msrb@suse.com>
Done-with: Fabian Vogt <fvogt@suse.de>
Task-number: QTBUG-66420
Change-Id: Iabb51d0eb2c0c16bde696efff623e57d15f28d82
Reviewed-by: Jesus Fernandez <Jesus.Fernandez@qt.io>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Diffstat (limited to 'mkspecs/win32-clang-g++')
0 files changed, 0 insertions, 0 deletions