diff options
author | Joerg Bornemann <joerg.bornemann@digia.com> | 2014-09-23 15:30:36 +0200 |
---|---|---|
committer | Joerg Bornemann <joerg.bornemann@digia.com> | 2014-09-25 11:23:31 +0200 |
commit | 5e6dc39770b22add23fafd7d1b07063e02a7907e (patch) | |
tree | a1e22ee2707c80820c8907724f7a3e07a139faf3 /qmake/generators/win32/msbuild_objectmodel.cpp | |
parent | 9a2b588556a0a789f826db2ccbbd3ff5baa21859 (diff) |
remove pointless initializations
Those initializations are done by the constructors already.
Change-Id: Ife58675e2ba4854ef66c813158cb4ed660f530d1
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@digia.com>
Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'qmake/generators/win32/msbuild_objectmodel.cpp')
-rw-r--r-- | qmake/generators/win32/msbuild_objectmodel.cpp | 13 |
1 files changed, 3 insertions, 10 deletions
diff --git a/qmake/generators/win32/msbuild_objectmodel.cpp b/qmake/generators/win32/msbuild_objectmodel.cpp index fcdea4a0a8..6311128d70 100644 --- a/qmake/generators/win32/msbuild_objectmodel.cpp +++ b/qmake/generators/win32/msbuild_objectmodel.cpp @@ -1848,7 +1848,7 @@ void VCXProjectWriter::outputFileConfigs(VCProject &project, XmlOutput &xml, Xml bool fileAdded = false; for (int i = 0; i < project.SingleProjects.count(); ++i) { - VCFilter filter = project.SingleProjects.at(i).filterByName(filtername); + const VCFilter &filter = project.SingleProjects.at(i).filterByName(filtername); if (filter.Config) // only if the filter is not empty if (outputFileConfig(filter, xml, xmlFilter, info.file, fileAdded)) // only add it once. fileAdded = true; @@ -1861,22 +1861,15 @@ void VCXProjectWriter::outputFileConfigs(VCProject &project, XmlOutput &xml, Xml xmlFilter << closetag(); } -bool VCXProjectWriter::outputFileConfig(VCFilter &filter, XmlOutput &xml, XmlOutput &xmlFilter, +bool VCXProjectWriter::outputFileConfig(VCFilter filter, XmlOutput &xml, XmlOutput &xmlFilter, const QString &filename, bool fileAdded) { // Clearing each filter tool filter.useCustomBuildTool = false; filter.useCompilerTool = false; filter.CustomBuildTool = VCCustomBuildTool(); - filter.CompilerTool = VCCLCompilerTool(); - - // Unset some default options filter.CustomBuildTool.config = filter.Config; - filter.CompilerTool.BufferSecurityCheck = unset; - filter.CompilerTool.DebugInformationFormat = debugUnknown; - filter.CompilerTool.ExceptionHandling = ehDefault; - filter.CompilerTool.ProgramDataBaseFileName.clear(); - filter.CompilerTool.RuntimeLibrary = rtUnknown; + filter.CompilerTool = VCCLCompilerTool(); filter.CompilerTool.config = filter.Config; bool inBuild = false; |