path: root/qmake/generators/win32/msvc_nmake.cpp
diff options
authorJoerg Bornemann <>2019-02-01 10:54:30 +0100
committerOliver Wolff <>2019-02-04 08:10:25 +0000
commit29d5a287abc3d3c9b75619db18042dea66236cb3 (patch)
tree2f9dfb27b1004818f96d010cc8cc22d13bf80cbe /qmake/generators/win32/msvc_nmake.cpp
parent3bf895c8d52a4172cd29ab8a8121e37ec790c47d (diff)
Make the Makefile a dependency of default targets for nmake
If the user changes the .pro file, the Makefile is supposed to be re-generated by calling qmake again. NMake however lacks a "Makefile remake feature" like GNU make has. The generated Makefiles for nmake however have already a proper Makefile target that can be used to re-generate the Makefile. What was missing is the dependency from an entry-target in the meta-Makefile. Now changes in the .pro file trigger a re-generation of Makefile.Debug/Makefile.Release when calling nmake without target arguments or with "debug" or "release". Fixes: QTBUG-29193 Change-Id: I9f2dd5deba4a043ab6c9502bb0b0ba83dc843612 Reviewed-by: Oliver Wolff <>
Diffstat (limited to 'qmake/generators/win32/msvc_nmake.cpp')
1 files changed, 5 insertions, 0 deletions
diff --git a/qmake/generators/win32/msvc_nmake.cpp b/qmake/generators/win32/msvc_nmake.cpp
index aa3d389b67..a6e850a036 100644
--- a/qmake/generators/win32/msvc_nmake.cpp
+++ b/qmake/generators/win32/msvc_nmake.cpp
@@ -76,6 +76,11 @@ void NmakeMakefileGenerator::writeSubMakeCall(QTextStream &t, const QString &cal
Win32MakefileGenerator::writeSubMakeCall(t, callPrefix, makeArguments);
+ProStringList NmakeMakefileGenerator::extraSubTargetDependencies()
+ return { "$(MAKEFILE)" };
QString NmakeMakefileGenerator::defaultInstall(const QString &t)
QString ret = Win32MakefileGenerator::defaultInstall(t);