diff options
author | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2015-09-22 12:47:19 +0200 |
---|---|---|
committer | Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com> | 2015-10-02 14:01:13 +0000 |
commit | c00e11d573447c0247f5db4a1141f6c307e0b36d (patch) | |
tree | 1764c3a0461f0780ddade8a0fdf160dbb3ef974b /qmake/meta.h | |
parent | 3e01f1ad3b19880628cf26e5395d34a1a9f2af05 (diff) |
make .prl processing less convoluted
don't look up the files and normalize the paths multiple times, as this
is inefficient and hard to understand.
on the way, processPrlFile() got unnested, and libExists() got nuked.
note that a missing QMAKE_PRL_TARGET will be now complained about, which
really should never happen.
Change-Id: Ibcd77a7f963204c013548496ecd2d635e1a4baba
Reviewed-by: Joerg Bornemann <joerg.bornemann@theqtcompany.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@theqtcompany.com>
Diffstat (limited to 'qmake/meta.h')
-rw-r--r-- | qmake/meta.h | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/qmake/meta.h b/qmake/meta.h index a1a30fbfa8..7c91ffda44 100644 --- a/qmake/meta.h +++ b/qmake/meta.h @@ -55,11 +55,11 @@ class QMakeMetaInfo public: QMakeMetaInfo(QMakeProject *_conf); - bool readLib(QString lib); - static QString findLib(QString lib); - static bool libExists(QString lib); - QString type() const; + // These functions expect the path to be normalized + static QString findLib(const QString &lib); + bool readLib(const QString &meta_file); + QString type() const; bool isEmpty(const ProKey &v); ProStringList &values(const ProKey &v); ProString first(const ProKey &v); @@ -91,9 +91,6 @@ inline ProString QMakeMetaInfo::first(const ProKey &v) inline ProValueMap &QMakeMetaInfo::variables() { return vars; } -inline bool QMakeMetaInfo::libExists(QString lib) -{ return !findLib(lib).isNull(); } - QT_END_NAMESPACE #endif // META_H |