path: root/qmake
diff options
authorJoão Abecasis <>2012-02-17 20:09:17 +0100
committerQt by Nokia <>2012-02-22 00:07:31 +0100
commit7bbe79fe5f54ed7542d935600036d3c8b401505f (patch)
treec37504bd357768150ea75b79b947ad570729ca5e /qmake
parent9beeb3030be3e0ab6513164b785fca3ade4c90e9 (diff)
Drop file-engine abstraction from public API
This abstraction imposed serious performance penalties and is being dropped from the public API. In particular, by allowing file names to be arbitrarily hijacked by different file engines, and requiring engines to be instantiated in order to decide, it imposed unnecessary overhead on all file operations. Another flaw in the design with direct impact on performance is how engines have no way to provide (or retain) additional information obtained when querying the filesystem. In many places this has meant repeated operations on the file system, where useful information is immediately discarded to be queried again subsequently. For Qt 4.8 a major refactoring of the code base took place to allow bypassing the file-engine abstraction in select places, with considerable performance gains observed. In Qt 5 it is expected we'll be able to take this further, reaping even more benefits, but the abstraction has to go. [Dropping this now does not preclude that virtual file systems make an appearance in Qt at a later point in Qt 5's lifecycle. Hopefully with a new and improved abstraction.] Forward declarations for QFileExtension(Result) were dropped, as the classes were never used or defined. Tests using "internalized" classes will only fully run on developer builds. QFSFileEngine was removed altogether from exception safety test, as it isn't its intent to test internal API. Change-Id: Ie910e6c2628be202ea9e05366b091d6d529b246b Reviewed-by: Thiago Macieira <> Reviewed-by: Lars Knoll <>
Diffstat (limited to 'qmake')
1 files changed, 1 insertions, 1 deletions
diff --git a/qmake/qmake.pri b/qmake/qmake.pri
index ba6ab383c7..abb073c48e 100644
--- a/qmake/qmake.pri
+++ b/qmake/qmake.pri
@@ -92,7 +92,7 @@ bootstrap { #Qt code
qdir_p.h \
qdiriterator.h \
qfile.h \
- qabstractfileengine.h \
+ qabstractfileengine_p.h \
qfileinfo.h \
qglobal.h \
qnumeric.h \