path: root/qmake
diff options
authorJuan Luis Boya García <>2013-10-23 12:34:02 +0200
committerThe Qt Project <>2013-10-25 14:51:30 +0200
commitc15e8517ef877a141df7cd5d4767d19ac81e7c2e (patch)
tree944b0ab2988d47aceef66da2c9ab6946a7bf52e3 /qmake
parentfcebbaeba37422780afd58a1a63954bdbf1a67e2 (diff)
Fix bug in updatePossibleKeyCodes() with dead keys and modifiers
As it was until now, QWindowsKeyMapper::updatePossibleKeyCodes() tested using ToUnicode for which characters produce a key with every possible combination of modifiers. Calling ToUnicode with a dead key is dangerous, because MS Windows keeps it in the driver buffer, so if you call ToUnicode with acute key and then you press a, you get an á. To prevent this, updatePossibleKeyCodes() checked if the key that was being tested was a dead key. If true, it inserted an space and then repeated the key in order to reset the system internal buffers to the same state they were before the call. The problem with this is if the dead key is really two keys (like ^ or ´ in US International keyboard layout) and you press one of those keys without the modifier to make it a dead key (i.e. 6 in US International): Since updatePossibleKeyCodes() only tests for the key that was pressed it gets 6 is not a dead key, and thus it does not execute the workaround. Thus, the next time the user presses 'a' they get 'â' instead because updatePossibleKeyCodes() set the dead key on the keyboard buffer and did not run the workaround. This patch makes updatePossibleKeyCodes() run the workaround if any possible combination of modifiers with the key being examinated makes a dead key. Task-number: QTBUG-33591 Change-Id: I8c0b27586f7c62798986258b1b84aa90e4c5d64c Reviewed-by: Oliver Wolff <> Reviewed-by: Friedemann Kleint <>
Diffstat (limited to 'qmake')
0 files changed, 0 insertions, 0 deletions