path: root/qmake
diff options
authorJoerg Bornemann <>2016-01-15 10:43:37 +0100
committerJoerg Bornemann <>2016-01-18 16:06:46 +0000
commitc60e06e087e3c7919ba7adb26f9cf44007238061 (patch)
tree1f497d435ad7e37538a28070e978dc26c126c5b6 /qmake
parent9eba208445ad3c6f8efeadc1e6c8befad4478d8f (diff)
Support precompiled header files without file extension in VS projects
Having a precompiled header file without file extension (or without common file extension) led to an incorrectly generated Visual Studio project file. The custom build step for automatically generating the corresponding source file was missing. Remove the file extension check that apparently was yet another feeble attempt of runtime optimization. Task-number: QTBUG-50442 Change-Id: I0552f94be12cbb70e2f32c242c7364699979bd81 Reviewed-by: Karsten Heimrich <> Reviewed-by: Oswald Buddenhagen <>
Diffstat (limited to 'qmake')
1 files changed, 1 insertions, 1 deletions
diff --git a/qmake/generators/win32/msvc_objectmodel.cpp b/qmake/generators/win32/msvc_objectmodel.cpp
index 18457ac5ad..f26dbbc40b 100644
--- a/qmake/generators/win32/msvc_objectmodel.cpp
+++ b/qmake/generators/win32/msvc_objectmodel.cpp
@@ -2196,7 +2196,7 @@ void VCFilter::modifyPCHstage(QString str)
- bool isHFile = Option::hasFileExtension(str, Option::h_ext) && (str == Project->precompH);
+ const bool isHFile = (str == Project->precompH);
bool isCPPFile = pchThroughSourceFile && (str == Project->precompCPP);
if(!isCFile && !isHFile && !isCPPFile)