diff options
| author | Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> | 2015-02-11 15:14:34 +0100 |
|---|---|---|
| committer | Friedemann Kleint <Friedemann.Kleint@theqtcompany.com> | 2015-02-14 16:24:40 +0000 |
| commit | e812358ba8570823e4d600561d45361c2edaaa3b (patch) | |
| tree | 8ea3b74a1994276ed45466ce0ffac6702a622ae5 /src/corelib/animation/qabstractanimation.cpp | |
| parent | 4dd7aeee10fc4d3883fd26fd70662405b533b6b4 (diff) | |
Animation classes: micro-optimize loops.
Don't use index-based iteration, but use iterators assigning
end() to a variable.
Change-Id: Ia87532349855fa3baa748b62224fc8adf3395dc0
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Diffstat (limited to 'src/corelib/animation/qabstractanimation.cpp')
| -rw-r--r-- | src/corelib/animation/qabstractanimation.cpp | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/src/corelib/animation/qabstractanimation.cpp b/src/corelib/animation/qabstractanimation.cpp index 7599c18cf2..7f2f01072f 100644 --- a/src/corelib/animation/qabstractanimation.cpp +++ b/src/corelib/animation/qabstractanimation.cpp @@ -154,6 +154,9 @@ QT_BEGIN_NAMESPACE +typedef QList<QAbstractAnimationTimer*>::ConstIterator TimerListConstIt; +typedef QList<QAbstractAnimation*>::ConstIterator AnimationListConstIt; + /*! \class QAbstractAnimationTimer \inmodule QtCore @@ -497,8 +500,8 @@ void QUnifiedTimer::resumeAnimationTimer(QAbstractAnimationTimer *timer) int QUnifiedTimer::closestPausedAnimationTimerTimeToFinish() { int closestTimeToFinish = INT_MAX; - for (int i = 0; i < pausedAnimationTimers.size(); ++i) { - int timeToFinish = pausedAnimationTimers.at(i)->pauseDuration; + for (TimerListConstIt it = pausedAnimationTimers.constBegin(), cend = pausedAnimationTimers.constEnd(); it != cend; ++it) { + const int timeToFinish = (*it)->pauseDuration; if (timeToFinish < closestTimeToFinish) closestTimeToFinish = timeToFinish; } @@ -726,8 +729,8 @@ void QAnimationTimer::unregisterRunningAnimation(QAbstractAnimation *animation) int QAnimationTimer::closestPauseAnimationTimeToFinish() { int closestTimeToFinish = INT_MAX; - for (int i = 0; i < runningPauseAnimations.size(); ++i) { - QAbstractAnimation *animation = runningPauseAnimations.at(i); + for (AnimationListConstIt it = runningPauseAnimations.constBegin(), cend = runningPauseAnimations.constEnd(); it != cend; ++it) { + const QAbstractAnimation *animation = *it; int timeToFinish; if (animation->direction() == QAbstractAnimation::Forward) |