Fix QAbstractFileEngine::clone misuse

QFile::copy was assuming that the target file was native and therefore
it could simply take the file descriptor to clone. While that was not
currently a problem, in theory it could be as we do have one writeable
file engine besides QFSFileEngine (QWinRTFileEngine).

By refactoring to take the parameter as a QAbstractFileEngine, we can
ensure that the target file is a native file.

Change-Id: Ib7a1737987bf4c4a8c51fffd14d0c048fd509025
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Lars Knoll <lars.knoll@qt.io>

1 files changed, 5 insertions, 4 deletions

diff --git a/src/corelib/io/qabstractfileengine.cpp b/src/corelib/io/qabstractfileengine.cpp
index 1163234b62..f2a895bbb8 100644
--- a/src/corelib/io/qabstractfileengine.cpp
+++ b/src/corelib/io/qabstractfileengine.cpp
@@ -864,13 +864,14 @@ bool QAbstractFileEngine::unmap(uchar *address)
 /*!
     \since 5.10
 
-    Copies the contents from the file specified by \a sourceHandle to this file
-    by cloning it.
+    Duplicates the contents of this file (starting from the current position)
+    to the file specified by the engine \a target.
+
     Returns \c true on success; otherwise, \c false is returned.
  */
-bool QAbstractFileEngine::clone(int sourceHandle)
+bool QAbstractFileEngine::cloneTo(QAbstractFileEngine *target)
 {
-    Q_UNUSED(sourceHandle);
+    Q_UNUSED(target);
     return false;
 }