diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2020-05-02 22:50:51 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2020-05-03 08:16:16 +0200 |
| commit | e62f6ffcb3b8a5bbeae7e6ce2d51f1fd0c96278c (patch) | |
| tree | 170afd992a4c2d00f1bb89f0b257757a96e020db /src/corelib/io/qdiriterator.cpp | |
| parent | 74306a02ce4e4d4c499d416885dd78d031bcb961 (diff) | |
QDirIterator: make a confusing condition less so
The old code checked for non-empty-ness before asking whether it
contains a certain path. But an empty container cannot contain any
path.
Simply remove the isEmpty() check.
Change-Id: Ie40279a8db4900c2f7892c2a058206d622565b10
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io/qdiriterator.cpp')
| -rw-r--r-- | src/corelib/io/qdiriterator.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/corelib/io/qdiriterator.cpp b/src/corelib/io/qdiriterator.cpp index bd4f1fd583..30d1c211c7 100644 --- a/src/corelib/io/qdiriterator.cpp +++ b/src/corelib/io/qdiriterator.cpp @@ -319,8 +319,7 @@ void QDirIteratorPrivate::checkAndPushDirectory(const QFileInfo &fileInfo) return; // Stop link loops - if (!visitedLinks.isEmpty() && - visitedLinks.contains(fileInfo.canonicalFilePath())) + if (visitedLinks.contains(fileInfo.canonicalFilePath())) return; pushDirectory(fileInfo); |