diff options
author | Marc Mutz <marc.mutz@qt.io> | 2024-02-07 11:56:38 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2024-02-17 17:20:52 +0100 |
commit | 1461fbb5d183e8894ad1a097c147dce21656bd01 (patch) | |
tree | fb28d224a8eb050435c0ec1e40baf90142968f3a /src/corelib/io/qloggingregistry.cpp | |
parent | 6b59ff573028eabba42ca63ce50ce05fa160ecaf (diff) |
QLoggingRegistry: cut out the QMap middle-man
In Qt 6, QMap is just a shared pointer to a std::map.
QLoggingRegistry::qtCategoryEnvironmentOverrides is never copied,
though, so the implicit sharing that QMap adds on top of std::map is
useless.
Use the underlying std::map directly.
Yes, the std::map API is a bit raw around the edges (std::pair
value_type), but we're professionals here.
This saves more than 1.1KiB in TEXT size on optimized AMD64 GCC 11
C++20 Linux builds.
Change-Id: Id72b2432ed41a97700cc2d9ecafa902b919efe84
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/corelib/io/qloggingregistry.cpp')
-rw-r--r-- | src/corelib/io/qloggingregistry.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/corelib/io/qloggingregistry.cpp b/src/corelib/io/qloggingregistry.cpp index f9728f9b72..8c9216ff62 100644 --- a/src/corelib/io/qloggingregistry.cpp +++ b/src/corelib/io/qloggingregistry.cpp @@ -350,7 +350,7 @@ void QLoggingRegistry::unregisterCategory(QLoggingCategory *cat) void QLoggingRegistry::registerEnvironmentOverrideForCategory(const char *categoryName, const char *environment) { - qtCategoryEnvironmentOverrides.insert(categoryName, environment); + qtCategoryEnvironmentOverrides.insert_or_assign(categoryName, environment); } /*! @@ -442,7 +442,7 @@ void QLoggingRegistry::defaultCategoryFilter(QLoggingCategory *cat) if (it == reg->qtCategoryEnvironmentOverrides.end()) debug = false; else - debug = qEnvironmentVariableIntValue(it.value()); + debug = qEnvironmentVariableIntValue(it->second); } } |