diff options
author | Alex Trotsenko <alex1973tr@gmail.com> | 2021-04-12 16:31:51 +0300 |
---|---|---|
committer | Oswald Buddenhagen <oswald.buddenhagen@gmx.de> | 2021-04-15 19:00:42 +0000 |
commit | 063cdb9870ab8a9b0f1a3741a001c06289f02af4 (patch) | |
tree | 3dcba5254f8ae4d2f250ffadaec0f93f865048e7 /src/corelib/io/qwindowspipewriter_p.h | |
parent | 92d351089bf7e285c9800342ff72205c04984f6c (diff) |
QWindowsPipe{Reader|Writer}: restructure signals
For QProcess, there is no point in suppressing recursive
QWPR::readyRead() emission, as the former manages this logic itself. On
top of that, the non-recursive nature of QWPR::readyRead() indirectly
disallowed reading from the channels inside
QProcess::waitForReadyRead(), if that is called from a slot connected
to QProcess::readyRead().
QWPW had two signals, one allowing recursion and one not.
This commit allows recursion of QWPR::readyRead() and
QWPW::bytesWritten(), and moves recursion suppression to the higher-
level classes. This makes the code more uniform and efficient, at the
cost of a few duplicated lines.
Change-Id: Ib20017fff4d92403d0bf2335f1622de4aa1ddcef
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Diffstat (limited to 'src/corelib/io/qwindowspipewriter_p.h')
-rw-r--r-- | src/corelib/io/qwindowspipewriter_p.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/corelib/io/qwindowspipewriter_p.h b/src/corelib/io/qwindowspipewriter_p.h index d33c2753a8..cb78195a85 100644 --- a/src/corelib/io/qwindowspipewriter_p.h +++ b/src/corelib/io/qwindowspipewriter_p.h @@ -77,7 +77,6 @@ public: HANDLE syncEvent() const { return syncHandle; } Q_SIGNALS: - void canWrite(); void bytesWritten(qint64 bytes); protected: @@ -104,7 +103,6 @@ private: bool writeSequenceStarted; bool bytesWrittenPending; bool winEventActPosted; - bool inBytesWritten; }; QT_END_NAMESPACE |