diff options
author | Marc Mutz <marc.mutz@qt.io> | 2023-12-13 13:25:15 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2023-12-13 21:54:01 +0100 |
commit | b6fdef44e46b97cf4dc5fee750f50054c65bf5ef (patch) | |
tree | 711c63915fea15f1295b321e137ea783f185eb54 /src/corelib/itemmodels/qsortfilterproxymodel.cpp | |
parent | 95c7f88132646489bc17b8ea32facd76a19e19fa (diff) |
QSortFilterProxyModel: scope a variable tighter
The clear() will not preserve capacity, since the QList has been
copied into proxy_intervals already, so is shared. But then creating a
new QList is just as efficient, or more so.
Pick-to: 6.7
Change-Id: I7ffd91bae8ded5ac28d58bcc545c479f6edc7c90
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/corelib/itemmodels/qsortfilterproxymodel.cpp')
-rw-r--r-- | src/corelib/itemmodels/qsortfilterproxymodel.cpp | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/src/corelib/itemmodels/qsortfilterproxymodel.cpp b/src/corelib/itemmodels/qsortfilterproxymodel.cpp index ddb9022d9e..c02fb7619b 100644 --- a/src/corelib/itemmodels/qsortfilterproxymodel.cpp +++ b/src/corelib/itemmodels/qsortfilterproxymodel.cpp @@ -832,10 +832,9 @@ QList<QPair<int, QList<int>>> QSortFilterProxyModelPrivate::proxy_intervals_for_ int proxy_low = 0; int proxy_item = 0; int source_items_index = 0; - QList<int> source_items_in_interval; bool compare = (orient == Qt::Vertical && source_sort_column >= 0 && dynamic_sortfilter); while (source_items_index < source_items.size()) { - source_items_in_interval.clear(); + QList<int> source_items_in_interval; int first_new_source_item = source_items.at(source_items_index); source_items_in_interval.append(first_new_source_item); ++source_items_index; |