summaryrefslogtreecommitdiffstats
path: root/src/corelib/kernel/qvariant.cpp
diff options
context:
space:
mode:
authorUlf Hermann <ulf.hermann@qt.io>2020-10-16 08:56:48 +0200
committerUlf Hermann <ulf.hermann@qt.io>2020-10-16 13:53:02 +0200
commitb3f3ebc2c0c9ba4142d553d02c86497377f4b3ef (patch)
tree52dd14524c7bbd94474165282ddecdd91a572346 /src/corelib/kernel/qvariant.cpp
parent382e3cb00f8703cd9b1774617e83bee7c44d87cf (diff)
Fix "variable set but unused" in qvariant.cpp
... how did that pass the CI? Change-Id: I84baaf3632df0410d1fb25f24fd22f65daae13af Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Diffstat (limited to 'src/corelib/kernel/qvariant.cpp')
-rw-r--r--src/corelib/kernel/qvariant.cpp2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/kernel/qvariant.cpp b/src/corelib/kernel/qvariant.cpp
index 1555b26d99..09c3eee6ea 100644
--- a/src/corelib/kernel/qvariant.cpp
+++ b/src/corelib/kernel/qvariant.cpp
@@ -2265,7 +2265,7 @@ int spaceShip(Numeric lhs, Numeric rhs) {
smaller = std::less<QObject *>()(lhs, rhs); // can't use less all the time because of bool
else
smaller = lhs < rhs;
- if (lhs < rhs)
+ if (smaller)
return -1;
else if (lhs == rhs)
return 0;