diff options
| author | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2024-02-01 11:39:58 +0100 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2024-02-02 16:23:02 +0100 |
| commit | 9f0dc59cd62f7afd18b36e6064f2d4b8ff2a7c6c (patch) | |
| tree | 0c4a42135b59d3ba2016a66c779ded36c59affed /src/corelib/kernel | |
| parent | 35fbb6561028a59702b12d6ff5e7cf310202ed0e (diff) | |
JNI: Don't use forwarding reference in ranged for
The elements we iterate over are always jobjects, i.e. POD, so iterating
over values is at least as efficient, and less unnecessarily clever.
Pick-to: 6.7
Change-Id: I6142dab84f3d37d82613ecf27cc03dde7810e541
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Diffstat (limited to 'src/corelib/kernel')
| -rw-r--r-- | src/corelib/kernel/qjniarray.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/kernel/qjniarray.h b/src/corelib/kernel/qjniarray.h index bfa5ec7a7c..16c02e087d 100644 --- a/src/corelib/kernel/qjniarray.h +++ b/src/corelib/kernel/qjniarray.h @@ -300,7 +300,7 @@ public: if constexpr (std::is_same_v<T, jobject>) { QList<jobject> res; res.reserve(size()); - for (auto &&element : *this) + for (auto element : *this) res.append(element); return res; } else if constexpr (std::is_same_v<T, jbyte>) { |