summaryrefslogtreecommitdiffstats
path: root/src/corelib/plugin/qlibrary.cpp
diff options
context:
space:
mode:
authorEdward Welbourne <edward.welbourne@qt.io>2021-09-30 12:50:05 +0200
committerEdward Welbourne <edward.welbourne@qt.io>2021-11-30 12:26:08 +0100
commitb9f7add531ceab2590e2b24dec7b495950f9870a (patch)
treebc6854cf33ec4847317b05edb5201fa4ed426605 /src/corelib/plugin/qlibrary.cpp
parent78a6e730075c1262f25b2ac2df098c7aa1184ca8 (diff)
Verify returns from QXmlTestLogger's xmlQuote() and xmlCdata()
Using partially-converted text would lead to invalid XML, so don't use the buffer contents if the return is zero. As a result, QTestJUnitStreamer::formatEnd() needs to return some indication of whether *it* succeeded, so change it to forward their int returns; and, as it's in fact only used internally by the streamer, make it private. Make these functions [[nodiscard]] so that further uses of them will be discouraged from ignoring the possibility of failure. Make the public versions return bool so that they can correctly succeed on empty input. Assert various conditions we can infer to save work we don't need to do. Change-Id: I899bad23d1dfbd05fc725de269def4ce213dbc5a Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'src/corelib/plugin/qlibrary.cpp')
0 files changed, 0 insertions, 0 deletions