summaryrefslogtreecommitdiffstats
path: root/src/corelib/plugin/qmachparser.cpp
diff options
context:
space:
mode:
authorThiago Macieira <thiago.macieira@intel.com>2013-03-01 14:29:17 -0800
committerThe Qt Project <gerrit-noreply@qt-project.org>2013-07-20 02:09:33 +0200
commit2b0cf53df77e4cc49d582b23bfec292eeca327c5 (patch)
treeae157b512c2b92ab2f0e4fe768685a97df5d4669 /src/corelib/plugin/qmachparser.cpp
parent62d636a666f38fb4483e2d528f1e175c90f5272a (diff)
Simplify the QLibrary plugin-detection code
The reason why the scanning of files was restricted to Unix is lost in history. My guess is that it was added *because* on Unix you couldn't do the LoadLibrary trick to load without dependencies. That is, it makes no comparison to whether scanning is faster than LoadLibrary. So assume that scanning is faster, especially now that we have memory mapping in QFile (it wasn't there in Qt 4.0). This simplifies greatly the codebase because we no longer need to try to load and later unload the library to check whether it is a Qt plugin or not, nor deal with Windows non-C++ exceptions. Just scan on all platforms. Change-Id: If269e009bfb9920805ca1aa6c2b66aacdd5b26e9 Reviewed-by: Morten Johan Sørvig <morten.sorvig@digia.com> Reviewed-by: Friedemann Kleint <Friedemann.Kleint@digia.com> Reviewed-by: Lars Knoll <lars.knoll@digia.com> Reviewed-by: Joerg Bornemann <joerg.bornemann@digia.com>
Diffstat (limited to 'src/corelib/plugin/qmachparser.cpp')
0 files changed, 0 insertions, 0 deletions