diff options
author | Richard Moe Gustavsen <richard.gustavsen@qt.io> | 2018-09-05 10:03:00 +0200 |
---|---|---|
committer | Richard Moe Gustavsen <richard.gustavsen@qt.io> | 2018-09-08 19:41:17 +0000 |
commit | 8d3b9841e1732337db67c79571567ac9294b3d7c (patch) | |
tree | d0ce8004edd60402caf4f00889d77610ca502b41 /src/corelib/serialization/qcbormap.cpp | |
parent | 5474f28c42ce0c853ddd08a8fd2f31948fcd968b (diff) |
Cocoa: change background color of selected menu items
Change 582d221b29 caused a regression when drawing menu items in
e.g a QComboBox. After that change, QCocoaSystemSettings would set the
QPalette::Highlight color to [NSColor selectedMenuItemTextColor]. But
the Highlight color is the background color, not the text color. And we
also use [NSColor selectedMenuItemTextColor] as the QPalette::HighlightedText
color. The result is that highlighed menu items end up with the same
foreground and background color (white), which means that they "disappear".
The color that we used before the patch, alternateSelectedControlColor, could
be used, but has the downside that it doesn't follow the appearance color in
system settings (like it should, compared to native apps). And it's also slightly
to blue. But using keyboardFocusIndicatorColor seems like a perfect match.
Fixes: QTBUG-69500
Change-Id: I07f091a5130a7308525743948d2a435226658a6f
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'src/corelib/serialization/qcbormap.cpp')
0 files changed, 0 insertions, 0 deletions