Smaller code cleanups in QList

Some cosmetics, but also some optimizations where we avoid a
temporary copy, or calling detach() twice.

Change-Id: I26803fdecf943ed9fab9baf58124091c7cebe1f3
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/src/corelib/tools/qarraydatapointer.h b/src/corelib/tools/qarraydatapointer.h
index 27b5b1ae74..26e8f934ee 100644
--- a/src/corelib/tools/qarraydatapointer.h
+++ b/src/corelib/tools/qarraydatapointer.h
@@ -162,17 +162,17 @@ public:
         swap(tmp);
     }
 
-    bool detach()
+    QArrayDataPointer detach()
     {
         if (needsDetach()) {
             QPair<Data *, T *> copy = clone();
             QArrayDataPointer old(d, ptr, size);
             d = copy.first;
             ptr = copy.second;
-            return true;
+            return old;
         }
 
-        return false;
+        return QArrayDataPointer();
     }
 
     // forwards from QArrayData