diff options
author | Thiago Macieira <thiago.macieira@intel.com> | 2012-06-11 13:38:41 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-06-12 20:09:39 +0200 |
commit | 08b3aceffe72668f578707c748c8180dbcf570cd (patch) | |
tree | dd71177d37ab31e6fe30c515fff3c39b56d39c99 /src/corelib/tools/qbytearray.h | |
parent | 48b38fb2b042fba5a0e1aed4f6d4fa6f29a51af0 (diff) |
Keep the #ifdef for tracking shared pointers in a single function
If we have it in different functions, then different out-of-line
implementations could be selected for each object file, resulting in
invalid states. The error I caught was when wrapper.cpp was compiled
without tracking and, therefore, did not place a call to
internalSafetyCheckAdd. However, it called an out-of-line copy of
QtSharedPointer::ExternalRefCountWithCustomDeleter::create, which did
set the deleter to remove the safety check.
Therefore, keep everything in one function.
Change-Id: Ib2c6a606699db49d102704bccdd331ec22a8bd78
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Diffstat (limited to 'src/corelib/tools/qbytearray.h')
0 files changed, 0 insertions, 0 deletions