diff options
| author | Kent Hansen <kent.hansen@nokia.com> | 2011-09-14 12:53:20 +0200 |
|---|---|---|
| committer | Qt by Nokia <qt-info@nokia.com> | 2011-09-15 20:39:28 +0200 |
| commit | 5639423ea7322d5880d68c61c480a3a084ac4f8b (patch) | |
| tree | 8b07bbb6e7ed6ad1972e6a0f816cfcb9a0819fd7 /src/corelib/tools/qchar.h | |
| parent | 4cd9d267e727b0b146f0f2d5b41cf62c97145fb4 (diff) | |
Boost performance of QChar::isDigit
Make it inline; add fast checks for ascii digits;
add fallback function that uses the fastcall calling
convention.
On ia32, this change makes isDigit ~370x faster for
ascii digit characters, ~250x faster for non-digit
ascii characters, and ~1.5x faster for non-ascii
characters.
Note that this change is NOT binary compatible.
Also add an autotest with expected results from
before the optimization, to ensure that the
behavior is the same.
Change-Id: I718fadecda3f591d6f4c22374d8e476f4724fd83
Reviewed-on: http://codereview.qt-project.org/4902
Reviewed-by: Qt Sanity Bot <qt_sanity_bot@ovi.com>
Reviewed-by: Lars Knoll <lars.knoll@nokia.com>
Diffstat (limited to 'src/corelib/tools/qchar.h')
| -rw-r--r-- | src/corelib/tools/qchar.h | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/src/corelib/tools/qchar.h b/src/corelib/tools/qchar.h index 3efa5e511d..801cb7d699 100644 --- a/src/corelib/tools/qchar.h +++ b/src/corelib/tools/qchar.h @@ -237,7 +237,8 @@ public: bool isLetter() const; bool isNumber() const; bool isLetterOrNumber() const; - bool isDigit() const; + inline bool isDigit() const + { return (ucs <= '9' && ucs >= '0') || (ucs > 127 && isDigit(ucs)); } bool isSymbol() const; inline bool isLower() const { return (ucs >= 'a' && ucs <= 'z') @@ -315,6 +316,8 @@ public: static QString QT_FASTCALL decomposition(uint ucs4); private: + static bool QT_FASTCALL isDigit(ushort ucs2); + #ifdef QT_NO_CAST_FROM_ASCII QChar(char c); QChar(uchar c); |