diff options
| author | David Faure <david.faure@kdab.com> | 2014-03-13 21:27:05 +0100 |
|---|---|---|
| committer | The Qt Project <gerrit-noreply@qt-project.org> | 2014-04-11 23:02:36 +0200 |
| commit | b526e44a37776861b187de62ebc4e21ba4c67cc4 (patch) | |
| tree | 8b40b9e8e2007d57635d9c54d1c724f95ba354b2 /src/corelib/tools/qdatetime.h | |
| parent | 4c1e15548a288455a5a62dcefacd7c9a44736346 (diff) | |
QtCore: Use Q_REQUIRED_RESULT in many more places
gcc doesn't yet warn when a non-POD return datatype is unused,
but clang does, at least.
This detected two bugs in qtbase due to the bad QDate method naming,
and will help application developers to avoid this trap too.
Change-Id: I106c1a32d2c6fc8d02f57beb7b61940605c80d76
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Diffstat (limited to 'src/corelib/tools/qdatetime.h')
| -rw-r--r-- | src/corelib/tools/qdatetime.h | 20 |
1 files changed, 10 insertions, 10 deletions
diff --git a/src/corelib/tools/qdatetime.h b/src/corelib/tools/qdatetime.h index b9f6995155..ac7296f742 100644 --- a/src/corelib/tools/qdatetime.h +++ b/src/corelib/tools/qdatetime.h @@ -94,9 +94,9 @@ QT_DEPRECATED inline bool setYMD(int y, int m, int d) void getDate(int *year, int *month, int *day); - QDate addDays(qint64 days) const; - QDate addMonths(int months) const; - QDate addYears(int years) const; + QDate addDays(qint64 days) const Q_REQUIRED_RESULT; + QDate addMonths(int months) const Q_REQUIRED_RESULT; + QDate addYears(int years) const Q_REQUIRED_RESULT; qint64 daysTo(const QDate &) const; bool operator==(const QDate &other) const { return jd == other.jd; } @@ -157,9 +157,9 @@ public: #endif bool setHMS(int h, int m, int s, int ms = 0); - QTime addSecs(int secs) const; + QTime addSecs(int secs) const Q_REQUIRED_RESULT; int secsTo(const QTime &) const; - QTime addMSecs(int ms) const; + QTime addMSecs(int ms) const Q_REQUIRED_RESULT; int msecsTo(const QTime &) const; bool operator==(const QTime &other) const { return mds == other.mds; } @@ -251,11 +251,11 @@ public: QString toString(Qt::DateFormat f = Qt::TextDate) const; QString toString(const QString &format) const; #endif - QDateTime addDays(qint64 days) const; - QDateTime addMonths(int months) const; - QDateTime addYears(int years) const; - QDateTime addSecs(qint64 secs) const; - QDateTime addMSecs(qint64 msecs) const; + QDateTime addDays(qint64 days) const Q_REQUIRED_RESULT; + QDateTime addMonths(int months) const Q_REQUIRED_RESULT; + QDateTime addYears(int years) const Q_REQUIRED_RESULT; + QDateTime addSecs(qint64 secs) const Q_REQUIRED_RESULT; + QDateTime addMSecs(qint64 msecs) const Q_REQUIRED_RESULT; QDateTime toTimeSpec(Qt::TimeSpec spec) const; inline QDateTime toLocalTime() const { return toTimeSpec(Qt::LocalTime); } |