diff options
author | Mårten Nordheim <marten.nordheim@qt.io> | 2022-08-26 22:24:04 +0200 |
---|---|---|
committer | Mårten Nordheim <marten.nordheim@qt.io> | 2022-08-28 18:49:52 +0200 |
commit | 52162eebe5339f53df4b3afb026e163e64b44ae2 (patch) | |
tree | 9f1ef8d038954647a17261c8361a0edab13fe1a6 /src/corelib/tools | |
parent | f039147165049dedcf6e1d92d902af28f566d753 (diff) |
QList: don't detach twice in operator[]
We first detached in operator[] itself, then in the data()
call.
Change-Id: I18b8b282b3b879125db350e0127953f83f773619
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Diffstat (limited to 'src/corelib/tools')
-rw-r--r-- | src/corelib/tools/qlist.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/corelib/tools/qlist.h b/src/corelib/tools/qlist.h index 0cc62e5f6e..ce161f62a1 100644 --- a/src/corelib/tools/qlist.h +++ b/src/corelib/tools/qlist.h @@ -426,7 +426,7 @@ public: reference operator[](qsizetype i) { Q_ASSERT_X(size_t(i) < size_t(d->size), "QList::operator[]", "index out of range"); - detach(); + // don't detach() here, we detach in data below: return data()[i]; } const_reference operator[](qsizetype i) const noexcept { return at(i); } |