diff options
| author | Edward Welbourne <edward.welbourne@qt.io> | 2024-04-10 16:58:14 +0200 |
|---|---|---|
| committer | Edward Welbourne <edward.welbourne@qt.io> | 2024-04-19 13:56:37 +0200 |
| commit | 020ed1c435dce07b7f1894b89954d3b228b3f822 (patch) | |
| tree | bdfa198ffdea8c7feba8d793f25e9c51da9f5d0c /src/corelib | |
| parent | 45639088d346b2a5ff8259e58a66f88afac2b480 (diff) | |
QDateTime and zone code: pass types by const ref if not trivial to copy
QTimeZone, QTimeZonePrivate::Data and QString are all big enough to
warrant passing by reference.
Task-number: QTBUG-122619
Change-Id: I7f2381316e47f40dd0faac0471967162d4ee6031
Reviewed-by: Juha Vuolle <juha.vuolle@qt.io>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Rym Bouabid <rym.bouabid@qt.io>
Diffstat (limited to 'src/corelib')
| -rw-r--r-- | src/corelib/time/qdatetime.cpp | 2 | ||||
| -rw-r--r-- | src/corelib/time/qtimezoneprivate.cpp | 2 | ||||
| -rw-r--r-- | src/corelib/time/qtimezoneprivate_tz.cpp | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/src/corelib/time/qdatetime.cpp b/src/corelib/time/qdatetime.cpp index 199fe0f015..687f174c07 100644 --- a/src/corelib/time/qdatetime.cpp +++ b/src/corelib/time/qdatetime.cpp @@ -3256,7 +3256,7 @@ static void checkValidDateTime(QDateTimeData &d, QDateTime::TransitionResolution } } -static void reviseTimeZone(QDateTimeData &d, QTimeZone zone, +static void reviseTimeZone(QDateTimeData &d, const QTimeZone &zone, QDateTime::TransitionResolution resolve) { Qt::TimeSpec spec = zone.timeSpec(); diff --git a/src/corelib/time/qtimezoneprivate.cpp b/src/corelib/time/qtimezoneprivate.cpp index 4c311878c8..2ad0d874b6 100644 --- a/src/corelib/time/qtimezoneprivate.cpp +++ b/src/corelib/time/qtimezoneprivate.cpp @@ -237,7 +237,7 @@ QTimeZonePrivate::Data QTimeZonePrivate::data(qint64 forMSecsSinceEpoch) const QDateTimePrivate::ZoneState QTimeZonePrivate::stateAtZoneTime( qint64 forLocalMSecs, QDateTimePrivate::TransitionOptions resolve) const { - auto dataToState = [](QTimeZonePrivate::Data d) { + auto dataToState = [](const QTimeZonePrivate::Data &d) { return QDateTimePrivate::ZoneState(d.atMSecsSinceEpoch + d.offsetFromUtc * 1000, d.offsetFromUtc, d.daylightTimeOffset ? QDateTimePrivate::DaylightTime diff --git a/src/corelib/time/qtimezoneprivate_tz.cpp b/src/corelib/time/qtimezoneprivate_tz.cpp index fce9deaa33..f6156fe93e 100644 --- a/src/corelib/time/qtimezoneprivate_tz.cpp +++ b/src/corelib/time/qtimezoneprivate_tz.cpp @@ -54,7 +54,7 @@ typedef QHash<QByteArray, QTzTimeZone> QTzTimeZoneHash; static bool isTzFile(const QString &name); // Open a named file under the zone info directory: -static bool openZoneInfo(QString name, QFile *file) +static bool openZoneInfo(const QString &name, QFile *file) { // At least on Linux / glibc (see man 3 tzset), $TZDIR overrides the system // default location for zone info: |