summaryrefslogtreecommitdiffstats
path: root/src/gui/configure.json
diff options
context:
space:
mode:
authorSona Kurazyan <sona.kurazyan@qt.io>2022-05-18 17:28:12 +0200
committerSona Kurazyan <sona.kurazyan@qt.io>2022-05-20 17:11:15 +0200
commitbd1023a824efeafbd48c79d4dfbdd5f017044ceb (patch)
tree49d7fb8e5e853f2fa6db5a8f066c3e285caf3bc7 /src/gui/configure.json
parentfa01e0bd71b42f0887790598106893c558557b60 (diff)
QtConcurrent: prevent conversion of ReduceOption to initial valueHEADdev
QtConcurrent map- and filter-reduce functions take an initial value, which can be of any type that is convertable to the result type. The side-effect of this is that the enum values passed as ReduceOptions can be treated as an initial value (if they are convertable to the result type) which will result into a wrong overload call. To avoid this, added additional check to make sure that the initial value type doesn't match with ReduceOption enum. Note that this required including the qtconcurrentreducekernel.h header in qtconcurrentfunctionwrappers.h (which contains compiler checks for QtConcurrent) for accessing ReduceOption enum, so I had to get rid of qtconcurrentfunctionwrappers.h include from qtconcurrentreducekernel.h to avoid circular header includes. This, in turn, required moving the QtPrivate::SequenceHolder helper type to qtconcurrentreducekernel.h, which didn't belong to qtconcurrentfunctionwrappers.h anyway. Pick-to: 6.3 6.2 Fixes: QTBUG-102999 Change-Id: Ieaa8ef2e4bd82ce2ada2e0af9a47b87b51d59e87 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Diffstat (limited to 'src/gui/configure.json')
0 files changed, 0 insertions, 0 deletions