diff options
author | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-08-26 13:12:21 +0300 |
---|---|---|
committer | Anton Kudryavtsev <a.kudryavtsev@netris.ru> | 2016-08-26 12:21:46 +0000 |
commit | d2f6f66a03482a0a694cf164ea11ff3513ab7f68 (patch) | |
tree | 42459341f6f2c2e81cbaab53b5fb257343015100 /src/gui/image/qiconloader.cpp | |
parent | 6621e6f89af123d51027e395588ec022bcd466c1 (diff) |
QIconCacheGtkReader: use QStringRef more
lookup() method now takes QStringRef arg.
Reduce allocations.
Change-Id: I556d01be5c5f268672121ab4c67c652cb6cfe090
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
Reviewed-by: Olivier Goffart (Woboq GmbH) <ogoffart@woboq.com>
Diffstat (limited to 'src/gui/image/qiconloader.cpp')
-rw-r--r-- | src/gui/image/qiconloader.cpp | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/gui/image/qiconloader.cpp b/src/gui/image/qiconloader.cpp index 0faf8820dd..e61a6bb48e 100644 --- a/src/gui/image/qiconloader.cpp +++ b/src/gui/image/qiconloader.cpp @@ -168,7 +168,7 @@ class QIconCacheGtkReader { public: explicit QIconCacheGtkReader(const QString &themeDir); - QVector<const char *> lookup(const QString &); + QVector<const char *> lookup(const QStringRef &); bool isValid() const { return m_isValid; } private: QFile m_file; @@ -241,7 +241,7 @@ static quint32 icon_name_hash(const char *p) with this name is present. The char* are pointers to the mapped data. For example, this would return { "32x32/apps", "24x24/apps" , ... } */ -QVector<const char *> QIconCacheGtkReader::lookup(const QString &name) +QVector<const char *> QIconCacheGtkReader::lookup(const QStringRef &name) { QVector<const char *> ret; if (!isValid()) @@ -394,7 +394,7 @@ QThemeIconInfo QIconLoader::findIconHelper(const QString &themeName, const QStringList contentDirs = theme.contentDirs(); - QString iconNameFallback = iconName; + QStringRef iconNameFallback(&iconName); // Iterate through all icon's fallbacks in current theme while (info.entries.isEmpty()) { @@ -451,7 +451,7 @@ QThemeIconInfo QIconLoader::findIconHelper(const QString &themeName, } if (!info.entries.isEmpty()) { - info.iconName = iconNameFallback; + info.iconName = iconNameFallback.toString(); break; } |