diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2014-08-16 13:04:23 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2015-06-24 13:23:13 +0000 |
commit | 419533eba413f136a46cf76e873bac01e7f3c881 (patch) | |
tree | d56b352b29355fd5dfe84ce460eb29279f5477d4 /src/gui/image/qpicture_p.h | |
parent | d0b659f1832a8bdd3ccc3a0769e38f3a8ea8fa9e (diff) |
QPicture: don't hold images in QList
QImage is larger than a void*, so holding them in a QList is needlessly
inefficient. Worse, the code could come to depend on the fragile property
of (inefficient) QLists that references to elements therein never are
invalidated.
Change-Id: I153995d691692f7317cab31b95a00d679f31c0af
Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>
Reviewed-by: Gunnar Sletta <gunnar@sletta.org>
Diffstat (limited to 'src/gui/image/qpicture_p.h')
-rw-r--r-- | src/gui/image/qpicture_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/image/qpicture_p.h b/src/gui/image/qpicture_p.h index d8623f0fed..a414a122f1 100644 --- a/src/gui/image/qpicture_p.h +++ b/src/gui/image/qpicture_p.h @@ -151,7 +151,7 @@ public: QRect override_rect; QScopedPointer<QPaintEngine> paintEngine; bool in_memory_only; - QList<QImage> image_list; + QVector<QImage> image_list; QVector<QPixmap> pixmap_list; QList<QBrush> brush_list; QList<QPen> pen_list; |