summaryrefslogtreecommitdiffstats
path: root/src/gui/image/qpixmapdata.cpp
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2024-05-27 15:39:35 +0200
committerMarc Mutz <marc.mutz@qt.io>2024-05-28 19:07:44 +0200
commit89f184b4034ce54b8a3439069e57b0f35798fec3 (patch)
treee1024e0b4aec352ea4c5499cc7b77d9e6f90aee8 /src/gui/image/qpixmapdata.cpp
parenta910daf52678469b7e595da5fe54aa09ba2373c3 (diff)
QLatin1StringView: fix UB in "a"_L1 <> nullptrHEADdev
Found by ubsan: if rhs is nullptr, then we fed a nullptr as the second argument of memcmp(), which is UB. Fix by catching an empty rhs before we reach that line. Amends e52d50a03da29e2dddaee551e4409f28c7ed56f2 (which, despite pick-to's to the contrary, never made it into 6.2 or 5.15). Change b977ae371a753a82e1d0bb32c5b62099da663721 fixed this for UTF-8/UTF-8 comparison from 6.5 on, but 6.4 ad 6.3 remain vulnerable there, but they're closed, so can't be fixed anymore. Pick-to: 6.7 6.5 Change-Id: I12fa986aa82a7440a9d53fad19a15e9420233e0b Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Diffstat (limited to 'src/gui/image/qpixmapdata.cpp')
0 files changed, 0 insertions, 0 deletions