diff options
author | Marc Mutz <marc.mutz@qt.io> | 2022-03-15 21:20:46 +0100 |
---|---|---|
committer | Marc Mutz <marc.mutz@qt.io> | 2022-03-19 16:56:08 +0100 |
commit | c839efb07a6aa3b487dac5f86f905f35ef2c3a08 (patch) | |
tree | 6345226a2b0e42cee27dd6f8c6149b86a9f0e25a /src/gui/kernel/qpalette.h | |
parent | 81fb9c5b14a89b47ea648c0a25f79b09ef7c92ad (diff) |
QtGui: compile-optimize inline swap functions
Instead of using the overly-generic qSwap() monster, use
- qt_ptr_swap() for swapping raw pointers
- member-swap for swapping smart pointers
- std::swap() for swapping scalars
In QtCore, this has proven to give a nice reduction in compile time
for Qt users, cf. b1b0c2970e480ef460a61f37fa430dc443390358.
Pick-to: 6.3 6.2
Task-number: QTBUG-97601
Change-Id: I987ff95e8751a22a4f283655d8225dd16de21178
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/gui/kernel/qpalette.h')
-rw-r--r-- | src/gui/kernel/qpalette.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gui/kernel/qpalette.h b/src/gui/kernel/qpalette.h index 776d489d44..8525ae8af4 100644 --- a/src/gui/kernel/qpalette.h +++ b/src/gui/kernel/qpalette.h @@ -74,8 +74,8 @@ public: void swap(QPalette &other) noexcept { - qSwap(currentGroup, other.currentGroup); - qSwap(d, other.d); + std::swap(currentGroup, other.currentGroup); + qt_ptr_swap(d, other.d); } operator QVariant() const; |