path: root/src/gui/kernel/qplatformdialoghelper.cpp
diff options
authorMarc Mutz <>2015-02-28 15:18:39 +0100
committerMarc Mutz <>2016-02-24 17:14:12 +0000
commit215bda50f959673f076fe76cf1f95a2a5f759b2c (patch)
tree302bf3b3edbc4da553b59fd5082e5a819501f444 /src/gui/kernel/qplatformdialoghelper.cpp
parent68a85a03f96f5912151ff7412c508e52a27c9418 (diff)
QtGui: replace QStringLiteral with QLatin1String when appending
It makes little sense to use QStringLiteral for strings which are immediately appended to, or which are appended to other strings, because no dynamic memory allocation is saved by doing so. But if the only advantage of QStringLiteral does not apply, all its disadvantages dominate, to wit: injection of calls to qstring dtor, non-sharability of data between C strings and QStringLiterals and among QStringLiterals, and doubled storage requirements. Fix by replacing QStringLiteral with QLatin1String. Saves 104B in text size on stripped optimized Linux AMD64 GCC 4.9 builds. Change-Id: I36b6a9bb1963b69361cc3a3db0971e1db92f0080 Reviewed-by: Olivier Goffart (Woboq GmbH) <>
Diffstat (limited to 'src/gui/kernel/qplatformdialoghelper.cpp')
1 files changed, 2 insertions, 2 deletions
diff --git a/src/gui/kernel/qplatformdialoghelper.cpp b/src/gui/kernel/qplatformdialoghelper.cpp
index f2a1d20d54..fe4d167078 100644
--- a/src/gui/kernel/qplatformdialoghelper.cpp
+++ b/src/gui/kernel/qplatformdialoghelper.cpp
@@ -258,7 +258,7 @@ void QColorDialogStaticData::readSettings()
const QSettings settings(QSettings::UserScope, QStringLiteral("QtProject"));
for (int i = 0; i < int(CustomColorCount); ++i) {
- const QVariant v = settings.value(QStringLiteral("Qt/customColors/") + QString::number(i));
+ const QVariant v = settings.value(QLatin1String("Qt/customColors/") + QString::number(i));
if (v.isValid())
customRgb[i] = v.toUInt();
@@ -271,7 +271,7 @@ void QColorDialogStaticData::writeSettings() const
if (!customSet) {
QSettings settings(QSettings::UserScope, QStringLiteral("QtProject"));
for (int i = 0; i < int(CustomColorCount); ++i)
- settings.setValue(QStringLiteral("Qt/customColors/") + QString::number(i), customRgb[i]);
+ settings.setValue(QLatin1String("Qt/customColors/") + QString::number(i), customRgb[i]);