diff options
author | Assam Boudjelthia <assam.boudjelthia@qt.io> | 2023-11-23 20:13:08 +0200 |
---|---|---|
committer | Assam Boudjelthia <assam.boudjelthia@qt.io> | 2023-11-28 02:11:56 +0200 |
commit | 4bc3f700ff86459a2a77ef211f9e727e245a0e20 (patch) | |
tree | 1d952f22d8455149f8c8ab84f1ff77c10a93390c /src/gui/kernel/qplatformoffscreensurface.cpp | |
parent | 518ac20dcb3cebf0956a399f40cbf51e9f3c188e (diff) |
Currently, under waitToFinish(), we wait for the app to start and if
it doesn't start or starts and exits too quickly for the test runner
to catch it, it fails. The test runner tries to get the pid of the test
after it detects the app has started. However, we don't really need to
fail, the test runner could simply continue the execution and assume
the test was run and finished, and proceed to fetching the test results.
Since, the results fetching don't anyway rely on the pid, the test
runner can let that operation decide whether to fail or not (if not
output is found).
Also, along the way, instead of issuing a different command to get the
pid (i.e. adb shell pidof), we can use the same "adb shell ps" command
that is used to check if the app is running, to obtain the pid.
Fixes: QTQAINFRA-5928
Fixes: QTBUG-88508
Pick-to: 6.6 6.5
Change-Id: Ice945fcb686c4ef21b5f1c143aa22922ae928333
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
Diffstat (limited to 'src/gui/kernel/qplatformoffscreensurface.cpp')
0 files changed, 0 insertions, 0 deletions