diff options
author | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-06-11 09:24:12 +0200 |
---|---|---|
committer | Friedemann Kleint <Friedemann.Kleint@qt.io> | 2020-07-14 10:25:47 +0200 |
commit | 37d5aaa4b42f9c837f0d27edb9da2185971d02be (patch) | |
tree | 867c23bfbff55f3d27dfee553ab20b015a938aa0 /src/gui/kernel/qwindow.cpp | |
parent | 80f7494e8a9f9a70e3b53833a098d74d8c2331d9 (diff) |
Change QWindow/QWidget::map(To/From)(Global/Parent) to operate in float
Change the functions to operate in float and add the
QPoint versions as overload calling them. This is
more in-line with the event accessors using float
and allows for removing some workarounds using a delta when
converting touch points.
Leave QPlatformWindow::map(To/From)Global() as is
for now and add helpers for float.
Change-Id: I2d46b8dbda8adff26539e358074b55073dc80b6f
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Diffstat (limited to 'src/gui/kernel/qwindow.cpp')
-rw-r--r-- | src/gui/kernel/qwindow.cpp | 35 |
1 files changed, 26 insertions, 9 deletions
diff --git a/src/gui/kernel/qwindow.cpp b/src/gui/kernel/qwindow.cpp index 9e11156c26..1ba81387a9 100644 --- a/src/gui/kernel/qwindow.cpp +++ b/src/gui/kernel/qwindow.cpp @@ -2631,51 +2631,68 @@ bool QWindow::nativeEvent(const QByteArray &eventType, void *message, long *resu } /*! - \fn QPoint QWindow::mapToGlobal(const QPoint &pos) const + \fn QPointF QWindow::mapToGlobal(const QPointF &pos) const Translates the window coordinate \a pos to global screen - coordinates. For example, \c{mapToGlobal(QPoint(0,0))} would give + coordinates. For example, \c{mapToGlobal(QPointF(0,0))} would give the global coordinates of the top-left pixel of the window. \sa mapFromGlobal() + \since 6.0 */ -QPoint QWindow::mapToGlobal(const QPoint &pos) const +QPointF QWindow::mapToGlobal(const QPointF &pos) const { Q_D(const QWindow); // QTBUG-43252, prefer platform implementation for foreign windows. if (d->platformWindow && (d->platformWindow->isForeignWindow() || d->platformWindow->isEmbedded())) { - return QHighDpi::fromNativeLocalPosition(d->platformWindow->mapToGlobal(QHighDpi::toNativeLocalPosition(pos, this)), this); + return QHighDpi::fromNativeLocalPosition(d->platformWindow->mapToGlobalF(QHighDpi::toNativeLocalPosition(pos, this)), this); } if (QHighDpiScaling::isActive()) return QHighDpiScaling::mapPositionToGlobal(pos, d->globalPosition(), this); - return pos + d->globalPosition(); + return pos + QPointF(d->globalPosition()); } +/*! + \overload +*/ +QPoint QWindow::mapToGlobal(const QPoint &pos) const +{ + return mapToGlobal(QPointF(pos)).toPoint(); +} /*! - \fn QPoint QWindow::mapFromGlobal(const QPoint &pos) const + \fn QPointF QWindow::mapFromGlobal(const QPointF &pos) const Translates the global screen coordinate \a pos to window coordinates. \sa mapToGlobal() + \since 6.0 */ -QPoint QWindow::mapFromGlobal(const QPoint &pos) const +QPointF QWindow::mapFromGlobal(const QPointF &pos) const { Q_D(const QWindow); // QTBUG-43252, prefer platform implementation for foreign windows. if (d->platformWindow && (d->platformWindow->isForeignWindow() || d->platformWindow->isEmbedded())) { - return QHighDpi::fromNativeLocalPosition(d->platformWindow->mapFromGlobal(QHighDpi::toNativeLocalPosition(pos, this)), this); + return QHighDpi::fromNativeLocalPosition(d->platformWindow->mapFromGlobalF(QHighDpi::toNativeLocalPosition(pos, this)), this); } if (QHighDpiScaling::isActive()) return QHighDpiScaling::mapPositionFromGlobal(pos, d->globalPosition(), this); - return pos - d->globalPosition(); + return pos - QPointF(d->globalPosition()); +} + +/*! + \overload +*/ +QPoint QWindow::mapFromGlobal(const QPoint &pos) const +{ + return QWindow::mapFromGlobal(QPointF(pos)).toPoint(); } QPoint QWindowPrivate::globalPosition() const |