summaryrefslogtreecommitdiffstats
path: root/src/gui/painting/qbezier.cpp
diff options
context:
space:
mode:
authorEirik Aavitsland <eirik.aavitsland@qt.io>2021-04-20 15:36:25 +0200
committerEirik Aavitsland <eirik.aavitsland@qt.io>2021-04-21 23:47:16 +0200
commit3a1be7dfcb7a4fd36a17e7af500b8d5a2954d611 (patch)
tree9409dde002933239e0b8c55029f559d9ea6b5ab7 /src/gui/painting/qbezier.cpp
parent3b8031059a14dd1d3bc65589a887092c22d2629b (diff)
Don't use qreal as a loop counter
Fix static analyzer warning Change-Id: I5c1a0c63e66b7c2511b4801bbe399681de998850 Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
Diffstat (limited to 'src/gui/painting/qbezier.cpp')
-rw-r--r--src/gui/painting/qbezier.cpp12
1 files changed, 7 insertions, 5 deletions
diff --git a/src/gui/painting/qbezier.cpp b/src/gui/painting/qbezier.cpp
index dabf1b0d23..b14843a703 100644
--- a/src/gui/painting/qbezier.cpp
+++ b/src/gui/painting/qbezier.cpp
@@ -217,15 +217,17 @@ static ShiftResult good_offset(const QBezier *b1, const QBezier *b2, qreal offse
const qreal o2 = offset*offset;
const qreal max_dist_line = threshold*offset*offset;
const qreal max_dist_normal = threshold*offset;
- const qreal spacing = qreal(0.25);
- for (qreal i = spacing; i < qreal(0.99); i += spacing) {
- QPointF p1 = b1->pointAt(i);
- QPointF p2 = b2->pointAt(i);
+ const int divisions = 4;
+ const qreal spacing = qreal(1.0) / divisions;
+ qreal t = spacing;
+ for (int i = 1; i < divisions; ++i, t += spacing) {
+ QPointF p1 = b1->pointAt(t);
+ QPointF p2 = b2->pointAt(t);
qreal d = (p1.x() - p2.x())*(p1.x() - p2.x()) + (p1.y() - p2.y())*(p1.y() - p2.y());
if (qAbs(d - o2) > max_dist_line)
return Split;
- QPointF normalPoint = b1->normalVector(i);
+ QPointF normalPoint = b1->normalVector(t);
qreal l = qAbs(normalPoint.x()) + qAbs(normalPoint.y());
if (l != qreal(0.0)) {
d = qAbs( normalPoint.x()*(p1.y() - p2.y()) - normalPoint.y()*(p1.x() - p2.x()) ) / l;