path: root/src/gui/painting/qtextureglyphcache_p.h
diff options
authorTor Arne Vestbø <>2014-12-09 16:50:05 +0100
committerTor Arne Vestbø <>2014-12-10 21:49:55 +0100
commite9222e199d587f48bd1d0e597aa295ebbe0531e3 (patch)
treee418e7085915584a9c81d2c3f8f7bd3ecc66f320 /src/gui/painting/qtextureglyphcache_p.h
parente79cdd0e6df7dec2edaea13b6cff45965c3e7456 (diff)
GL2PaintEngine: Prevent fillInPendingGlyphs from breaking gradients
The glyph cache internally uses the image texture unit when blitting, but doesn't always activate the unit before binding its texture, resulting in sometimes binding the glyph cache texture to the wrong unit. The image texture unit is also the same as the brush texture unit, so any time we fill in pending glyphs we need to re-bind the brush texture, otherwise drawing text with eg. gradients will fail after the new glyphs have been filled. The new hasPendingGlyphs() member function of the glyph cache is an optimization so that we don't need to activate and rebind unless there are glyphs that need to be filled. Change-Id: Iac74130145d2d6d7bf95206b5e8a2fc760743cb5 Reviewed-by: Laszlo Agocs <> Reviewed-by: Tor Arne Vestbø <>
Diffstat (limited to 'src/gui/painting/qtextureglyphcache_p.h')
1 files changed, 1 insertions, 0 deletions
diff --git a/src/gui/painting/qtextureglyphcache_p.h b/src/gui/painting/qtextureglyphcache_p.h
index 50c2c9dcc6..2d2fcdfc93 100644
--- a/src/gui/painting/qtextureglyphcache_p.h
+++ b/src/gui/painting/qtextureglyphcache_p.h
@@ -104,6 +104,7 @@ public:
bool populate(QFontEngine *fontEngine, int numGlyphs, const glyph_t *glyphs,
const QFixedPoint *positions);
+ bool hasPendingGlyphs() const { return !m_pendingGlyphs.isEmpty(); };
void fillInPendingGlyphs();
virtual void createTextureData(int width, int height) = 0;