path: root/src/gui/text
diff options
authorMarc Mutz <>2023-01-31 11:06:56 +0100
committerMarc Mutz <>2023-02-01 12:21:23 +0000
commit4c445ef0bae8b36ec4a742552f0ebd81a1a90723 (patch)
tree327f380bcf4e4cea3dfe1844f8a8f63c125f0eff /src/gui/text
parenta1d43b8334f71055da606b3546d482cbcff08170 (diff)
ODBC SQL driver: fix conversion of QByteArray to QVLA<SQLTCHAR>HEADdev
The QByteArray is assumed to contain an SQLTCHAR string (so, either UTF-8, UTF-16 or UTF-32-encoded). Only in the UTF-8 case would the size of the byte array be the same as the size of the SQLTCHAR string in codepoints, yet the size in bytes is what the code passed to the QVLA<SQLTCHAR> append() call, causing it to read past the QByteArray buffer in the UTF-16 and UTF-32 cases. Fix by properly calculating the string size from the size-in-bytes and then memcpy()ing into the QVLA. We use memcpy() and not QVLA::append(T*, n) because the QByteArray buffer need not be aligned on an alignof(SQLTCHAR) boundary (certainly not since it gained the prepend "optimization"). Pick-to: 6.5 6.4 6.2 5.15 Change-Id: If3838c3dee89e6aca65541242642315b8e1fa6b4 Reviewed-by: Thiago Macieira <>
Diffstat (limited to 'src/gui/text')
0 files changed, 0 insertions, 0 deletions