path: root/src/gui/text/qtextdocument_p.cpp
diff options
authorDavid Faure <>2017-02-20 10:55:59 +0100
committerDavid Faure <>2017-02-23 18:11:55 +0000
commit90b48a70ffb64d97211150fa0849dc0fa0023b7d (patch)
tree1dc0532f52bf05799dba5d627a753777932f6cf2 /src/gui/text/qtextdocument_p.cpp
parent8e9582847506bf17755415fdddd92c242407851c (diff)
QTextFormatCollection: replace copy ctor and op= with clear()
operator=, which was only used for clearing, wasn't clearing the hash. This led to a mismatch between the vector and the hash (given that the hash points into the vector). Spotted by interrupting kmail in gdb, and it was in this code iterating over a 2000 entries hash (the first vector entries not matching the hash, this code keep appending new entries for the same formats). This fixes QTBUG-8862 again, the initial fix having been accidentally reverted in 467b15a. Change-Id: Ia34b3d002a0199e1930431a4bbdb2ec981ed4ffc Task-number: QTBUG-8862 Reviewed-by: Olivier Goffart (Woboq GmbH) <>
Diffstat (limited to 'src/gui/text/qtextdocument_p.cpp')
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/text/qtextdocument_p.cpp b/src/gui/text/qtextdocument_p.cpp
index 7107c7c26e..7341fa8e83 100644
--- a/src/gui/text/qtextdocument_p.cpp
+++ b/src/gui/text/qtextdocument_p.cpp
@@ -265,7 +265,7 @@ void QTextDocumentPrivate::clear()
unreachableCharacterCount = 0;
modifiedState = 0;
modified = false;
- formats = QTextFormatCollection();
+ formats.clear();
int len = fragments.length();