diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2014-08-17 20:44:39 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2015-07-19 10:35:41 +0000 |
| commit | 0abd207052a23759a64ebbabbe46b6c2cdf07a5f (patch) | |
| tree | 502d6d0ed54df8a4805515caa70c56fbbb66f0e3 /src/gui/text/qzipreader_p.h | |
| parent | 78bba7b0029f9c626f0c686339dec9a9bf9466c6 (diff) | |
QZip*: don't hold QZipReader::FileInfo in QList
FileInfo is larger than a void*, so holding them in a QList is needlessly
inefficient. Worse, the code could come to depend on the fragile property
of (inefficient) QLists that references to elements therein never are
invalidated.
Change-Id: I772177c5ac544a5fecce2368f628148308ef260f
Reviewed-by: Konstantin Ritt <ritt.ks@gmail.com>
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Diffstat (limited to 'src/gui/text/qzipreader_p.h')
| -rw-r--r-- | src/gui/text/qzipreader_p.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/gui/text/qzipreader_p.h b/src/gui/text/qzipreader_p.h index e4026285b2..7f26bfb184 100644 --- a/src/gui/text/qzipreader_p.h +++ b/src/gui/text/qzipreader_p.h @@ -88,7 +88,7 @@ public: QDateTime lastModified; }; - QList<FileInfo> fileInfoList() const; + QVector<FileInfo> fileInfoList() const; int count() const; FileInfo entryInfoAt(int index) const; |