diff options
author | Albert Astals Cid <aacid@kde.org> | 2012-06-23 11:06:43 +0200 |
---|---|---|
committer | Qt by Nokia <qt-info@nokia.com> | 2012-06-27 14:43:00 +0200 |
commit | 175c69108a5b3c81d32b775f01d1e811289c89c6 (patch) | |
tree | b42f7c9d946c5eccbc8e9f881c5db62579bf19ab /src/gui | |
parent | 1b6c83f7a3668e39df9d5e468fa693b0aa0c8b0e (diff) |
Add const & to foreach 'iterators'
Change-Id: I8c0600dfd919f45d14a0011f2da9b9fe0b9a0df3
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Robin Burchell <robin+qt@viroteck.net>
Diffstat (limited to 'src/gui')
-rw-r--r-- | src/gui/image/qimagereader.cpp | 2 | ||||
-rw-r--r-- | src/gui/text/qtextengine.cpp | 2 | ||||
-rw-r--r-- | src/gui/text/qzip.cpp | 6 |
3 files changed, 5 insertions, 5 deletions
diff --git a/src/gui/image/qimagereader.cpp b/src/gui/image/qimagereader.cpp index 4cda7304ac..9052187426 100644 --- a/src/gui/image/qimagereader.cpp +++ b/src/gui/image/qimagereader.cpp @@ -605,7 +605,7 @@ void QImageReaderPrivate::getText() { if (!text.isEmpty() || (!handler && !initHandler()) || !handler->supportsOption(QImageIOHandler::Description)) return; - foreach (QString pair, handler->option(QImageIOHandler::Description).toString().split( + foreach (const QString &pair, handler->option(QImageIOHandler::Description).toString().split( QLatin1String("\n\n"))) { int index = pair.indexOf(QLatin1Char(':')); if (index >= 0 && pair.indexOf(QLatin1Char(' ')) < index) { diff --git a/src/gui/text/qtextengine.cpp b/src/gui/text/qtextengine.cpp index 11dded8ef3..df1e1533fb 100644 --- a/src/gui/text/qtextengine.cpp +++ b/src/gui/text/qtextengine.cpp @@ -2981,7 +2981,7 @@ void QTextEngine::drawItemDecorationList(QPainter *painter, const ItemDecoration if (decorationList.isEmpty()) return; - foreach (const ItemDecoration decoration, decorationList) { + foreach (const ItemDecoration &decoration, decorationList) { painter->setPen(decoration.pen); QLineF line(decoration.x1, decoration.y, decoration.x2, decoration.y); painter->drawLine(line); diff --git a/src/gui/text/qzip.cpp b/src/gui/text/qzip.cpp index d1bc94a822..b22b5fffda 100644 --- a/src/gui/text/qzip.cpp +++ b/src/gui/text/qzip.cpp @@ -1052,7 +1052,7 @@ bool QZipReader::extractAll(const QString &destinationDir) const // create directories first QList<FileInfo> allFiles = fileInfoList(); - foreach (FileInfo fi, allFiles) { + foreach (const FileInfo &fi, allFiles) { const QString absPath = destinationDir + QDir::separator() + fi.filePath; if (fi.isDir) { if (!baseDir.mkpath(fi.filePath)) @@ -1063,7 +1063,7 @@ bool QZipReader::extractAll(const QString &destinationDir) const } // set up symlinks - foreach (FileInfo fi, allFiles) { + foreach (const FileInfo &fi, allFiles) { const QString absPath = destinationDir + QDir::separator() + fi.filePath; if (fi.isSymLink) { QString destination = QFile::decodeName(fileData(fi.filePath)); @@ -1081,7 +1081,7 @@ bool QZipReader::extractAll(const QString &destinationDir) const } } - foreach (FileInfo fi, allFiles) { + foreach (const FileInfo &fi, allFiles) { const QString absPath = destinationDir + QDir::separator() + fi.filePath; if (fi.isFile) { QFile f(absPath); |