diff options
author | Edward Welbourne <edward.welbourne@qt.io> | 2021-07-19 16:22:30 +0200 |
---|---|---|
committer | Edward Welbourne <edward.welbourne@qt.io> | 2021-07-22 18:49:16 +0200 |
commit | b5950f6aff9ca646c55e640dd3d67105f56070e1 (patch) | |
tree | d55d02a856f3dac60403e8718454bbed1b56d2cb /src/gui | |
parent | 9159ce0373d5faf852eea69462ba73ea7224fbca (diff) |
Use QChar::fromUcs4(i) rather than QChar(i) on out-of-range i
Follow-up to commit 915be6606ead25f4fbbbcb2687b33cf22a955177, catching
some benchmarks that took for granted they can assign an arbitrary int
to QChar. Since 6.0 this has triggered an assertion.
Given the choice between limiting the range (from 100000 to 0x10000)
and actually handling the out-of-range values as UCS-4 data, the
latter seemed like a more interesting test.
At the same time, take the construction of the strings out of the
loop, as that's not a QMap performance matter, it's a QString one.
Pick-to: 6.1 6.2
Task-number: QTBUG-91713
Change-Id: Id6abab08b5c879f0f764350f66d6aa1dd9f1620a
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
Diffstat (limited to 'src/gui')
0 files changed, 0 insertions, 0 deletions