summaryrefslogtreecommitdiffstats
path: root/src/gui
diff options
context:
space:
mode:
authorShawn Rutledge <shawn.rutledge@qt.io>2017-08-17 10:32:50 +0200
committerTor Arne Vestbø <tor.arne.vestbo@qt.io>2017-08-18 12:40:01 +0000
commitdfdb94410a3b77381f20e426a2420065be9631f9 (patch)
tree71b679d3ca79ca51e6646759b6111248b809c028 /src/gui
parent3ce555a3de71725e83cd4e6cbd4da9ca1bc7ba20 (diff)
Revert "macOS: Create NSView as initially hidden, to match QWindow behavior"
It seems to break the ability to grab an offscreen QQuickView. That in turn breaks the tst_qquickimage::hugeImages autotest. This reverts commit 096b56f336e5bb994d46f073d55496d36d38e6b1. Task-number: QTBUG-62548 Change-Id: I11ce452341bfc2cc3cbc832b613c7366049b31d5 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Diffstat (limited to 'src/gui')
-rw-r--r--src/gui/kernel/qwindow.cpp9
1 files changed, 1 insertions, 8 deletions
diff --git a/src/gui/kernel/qwindow.cpp b/src/gui/kernel/qwindow.cpp
index ac2c79b9ab..1d8d6dfc95 100644
--- a/src/gui/kernel/qwindow.cpp
+++ b/src/gui/kernel/qwindow.cpp
@@ -343,15 +343,8 @@ void QWindowPrivate::setVisible(bool visible)
return;
// We only need to create the window if it's being shown
- if (visible) {
- // FIXME: At this point we've already updated the visible state of
- // the QWindow, so any platform pulling out the visible state during
- // creation to set on the native window will create a visible window,
- // which may result in resize and expose events before the show event
- // sent below. This code assumes that the platform will set the window
- // to be hidden, until receiving a setVisible call below.
+ if (visible)
q->create();
- }
}
if (visible) {