diff options
author | Marc Mutz <marc.mutz@kdab.com> | 2021-07-10 23:17:04 +0200 |
---|---|---|
committer | Marc Mutz <marc.mutz@kdab.com> | 2021-07-28 02:01:21 +0200 |
commit | 99f0db695ab54ba0cd88c6a53ddd2d712525ecc3 (patch) | |
tree | d9e019d8bcd511916c88626f6aa201833be7ee8f /src/network/access/qhttpthreaddelegate_p.h | |
parent | 017eb5627b2389089c46d7f226f233651e7c0458 (diff) |
QNetworkReply: hold QAtomicInt in shared_ptr, not QSharedPointer
Ditto QNetworkAccessAuthenticationManager.
QSharedPointer performs twice as many atomic operations per pointer
copy as std::shared_ptr, and this is private API, we're not bound by
BC constraints, so we can port to the more efficient version.
Change-Id: I59dc09ff4eb3b4acf5d7a68695752a9a7110d8d3
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/network/access/qhttpthreaddelegate_p.h')
-rw-r--r-- | src/network/access/qhttpthreaddelegate_p.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/network/access/qhttpthreaddelegate_p.h b/src/network/access/qhttpthreaddelegate_p.h index f0b9b8edf3..bdafeb3693 100644 --- a/src/network/access/qhttpthreaddelegate_p.h +++ b/src/network/access/qhttpthreaddelegate_p.h @@ -97,13 +97,13 @@ public: qint64 readBufferMaxSize; qint64 bytesEmitted; // From backend, modified by us for signal compression - QSharedPointer<QAtomicInt> pendingDownloadData; - QSharedPointer<QAtomicInt> pendingDownloadProgress; + std::shared_ptr<QAtomicInt> pendingDownloadData; + std::shared_ptr<QAtomicInt> pendingDownloadProgress; #ifndef QT_NO_NETWORKPROXY QNetworkProxy cacheProxy; QNetworkProxy transparentProxy; #endif - QSharedPointer<QNetworkAccessAuthenticationManager> authenticationManager; + std::shared_ptr<QNetworkAccessAuthenticationManager> authenticationManager; bool synchronous; qint64 connectionCacheExpiryTimeoutSeconds; |