diff options
author | Anton Kudryavtsev <anton.kudryavtsev@vk.team> | 2023-08-24 17:28:46 +0300 |
---|---|---|
committer | Anton Kudryavtsev <anton.kudryavtsev@vk.team> | 2023-08-28 19:11:15 +0300 |
commit | 6cc1a8400520e1c840d076ceca00dfd538da5d46 (patch) | |
tree | f0be96c20d390f17b8b3b1322043e31868d4ec13 /src/network/access/qnetworkrequest.cpp | |
parent | 5c5c9dd830ecaa5dc1be80ef8199d7077096b61e (diff) |
qnetworkrequest: reduce branches in loop
Unconditionally append separator and then chop last one
Change-Id: I33d004df07ce0c3c0076dc374ae7a2f8c413aeba
Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/network/access/qnetworkrequest.cpp')
-rw-r--r-- | src/network/access/qnetworkrequest.cpp | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/src/network/access/qnetworkrequest.cpp b/src/network/access/qnetworkrequest.cpp index a7a5ca5e39..0272ff1899 100644 --- a/src/network/access/qnetworkrequest.cpp +++ b/src/network/access/qnetworkrequest.cpp @@ -1096,14 +1096,14 @@ static QByteArray headerValue(QNetworkRequest::KnownHeaders header, const QVaria if (cookies.isEmpty() && value.userType() == qMetaTypeId<QNetworkCookie>()) cookies << qvariant_cast<QNetworkCookie>(value); + constexpr QByteArrayView separator = "; "; QByteArray result; - bool first = true; for (const QNetworkCookie &cookie : std::as_const(cookies)) { - if (!first) - result += "; "; - first = false; result += cookie.toRawForm(QNetworkCookie::NameAndValueOnly); + result += separator; } + if (!result.isEmpty()) + result.chop(separator.size()); return result; } @@ -1111,15 +1111,15 @@ static QByteArray headerValue(QNetworkRequest::KnownHeaders header, const QVaria QList<QNetworkCookie> cookies = qvariant_cast<QList<QNetworkCookie> >(value); if (cookies.isEmpty() && value.userType() == qMetaTypeId<QNetworkCookie>()) cookies << qvariant_cast<QNetworkCookie>(value); - +\ + constexpr QByteArrayView separator = ", "; QByteArray result; - bool first = true; for (const QNetworkCookie &cookie : std::as_const(cookies)) { - if (!first) - result += ", "; - first = false; result += cookie.toRawForm(QNetworkCookie::Full); + result += separator; } + if (!result.isEmpty()) + result.chop(separator.size()); return result; } } |