Rename the replace() function's value to newValue to reflect its role

Found in API-review

Pick-to: 6.7
Change-Id: Ib047c79d977ad6870c1e426cd1add994a3634df4
Reviewed-by: Ivan Solovev <ivan.solovev@qt.io>
Reviewed-by: Marc Mutz <marc.mutz@qt.io>

2 files changed, 9 insertions, 9 deletions

diff --git a/src/network/access/qhttpheaders.cpp b/src/network/access/qhttpheaders.cpp
index fbe0236f65..41897cacd5 100644
--- a/src/network/access/qhttpheaders.cpp
+++ b/src/network/access/qhttpheaders.cpp
@@ -869,7 +869,7 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
 }
 
 /*!
-    Replaces the header entry at index \a i, with \a name and \a value.
+    Replaces the header entry at index \a i, with \a name and \a newValue.
     The index must be valid (see \l size()). Returns whether the replace
     succeeded.
 
@@ -877,28 +877,28 @@ bool QHttpHeaders::insert(qsizetype i, WellKnownHeader name, QAnyStringView valu
       replace(qsizetype, QHttpHeaders::WellKnownHeader, QAnyStringView), size()
     \sa {Allowed field name and value characters}
 */
-bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView value)
+bool QHttpHeaders::replace(qsizetype i, QAnyStringView name, QAnyStringView newValue)
 {
     d->verify(i);
-    if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(value))
+    if (!isValidHttpHeaderNameField(name) || !isValidHttpHeaderValueField(newValue))
         return false;
 
     d.detach();
-    d->headers.replace(i, {normalizedName(name), normalizedValue(value)});
+    d->headers.replace(i, {normalizedName(name), normalizedValue(newValue)});
     return true;
 }
 
 /*!
     \overload replace(qsizetype, QAnyStringView, QAnyStringView)
 */
-bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView value)
+bool QHttpHeaders::replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue)
 {
     d->verify(i);
-    if (!isValidHttpHeaderValueField(value))
+    if (!isValidHttpHeaderValueField(newValue))
         return false;
 
     d.detach();
-    d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(value)});
+    d->headers.replace(i, {headerNames[qToUnderlying(name)], normalizedValue(newValue)});
     return true;
 }
 
diff --git a/src/network/access/qhttpheaders.h b/src/network/access/qhttpheaders.h
index f39afcc96e..df53cd6694 100644
--- a/src/network/access/qhttpheaders.h
+++ b/src/network/access/qhttpheaders.h
@@ -222,8 +222,8 @@ public:
     Q_NETWORK_EXPORT bool insert(qsizetype i, QAnyStringView name, QAnyStringView value);
     Q_NETWORK_EXPORT bool insert(qsizetype i, WellKnownHeader name, QAnyStringView value);
 
-    Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView value);
-    Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView value);
+    Q_NETWORK_EXPORT bool replace(qsizetype i, QAnyStringView name, QAnyStringView newValue);
+    Q_NETWORK_EXPORT bool replace(qsizetype i, WellKnownHeader name, QAnyStringView newValue);
 
     Q_NETWORK_EXPORT bool contains(QAnyStringView name) const;
     Q_NETWORK_EXPORT bool contains(WellKnownHeader name) const;