diff options
| author | Marc Mutz <marc.mutz@kdab.com> | 2021-07-06 08:12:00 +0200 |
|---|---|---|
| committer | Marc Mutz <marc.mutz@kdab.com> | 2021-07-07 23:49:26 +0000 |
| commit | e9fffbaf81ec81685cb6a5d75844cd700183ab9e (patch) | |
| tree | 4bb6021e7d7040a1d88efd53448271915414024c /src/network/access | |
| parent | bd62dc13919556c6dc564df25cbf0ddf456c05e7 (diff) | |
Use QCryptographicHash::hash() more widely
... instead of the "usual" rule of three: ctor, addData(), result().
Not only does it generate less code in the caller, it's now also
faster.
Change-Id: I67c7eeb01f527b90e80a08f60c1c7f2ec1e49dd4
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Diffstat (limited to 'src/network/access')
| -rw-r--r-- | src/network/access/qnetworkdiskcache.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/src/network/access/qnetworkdiskcache.cpp b/src/network/access/qnetworkdiskcache.cpp index d3320d05e3..6f02405c0f 100644 --- a/src/network/access/qnetworkdiskcache.cpp +++ b/src/network/access/qnetworkdiskcache.cpp @@ -594,10 +594,9 @@ QString QNetworkDiskCachePrivate::uniqueFileName(const QUrl &url) cleanUrl.setPassword(QString()); cleanUrl.setFragment(QString()); - QCryptographicHash hash(QCryptographicHash::Sha1); - hash.addData(cleanUrl.toEncoded()); + const QByteArray hash = QCryptographicHash::hash(cleanUrl.toEncoded(), QCryptographicHash::Sha1); // convert sha1 to base36 form and return first 8 bytes for use as string - const QByteArray id = QByteArray::number(*(qlonglong*)hash.result().constData(), 36).left(8); + const QByteArray id = QByteArray::number(*(qlonglong*)hash.data(), 36).left(8); // generates <one-char subdir>/<8-char filname.d> uint code = (uint)id.at(id.length()-1) % 16; QString pathFragment = QString::number(code, 16) + QLatin1Char('/') |