summaryrefslogtreecommitdiffstats
path: root/src/network/access
diff options
context:
space:
mode:
authorMarc Mutz <marc.mutz@qt.io>2024-01-18 09:32:00 +0100
committerMarc Mutz <marc.mutz@qt.io>2024-01-18 14:49:22 +0000
commitfab57c25e22239516dec737f2d42a7fccae9d37f (patch)
treeba0e917f305c3e3dfaf86041017dc96bac79964e /src/network/access
parent26b8e99b1ce616a063fcbd0d67f44ba9e7712f23 (diff)
QH2Expected: use Rule Of Zero
It doesn't always pay to be explicit about SMFs. In the present case, clang-tidy complains that the move ctors of the class aren't noexcept. It's a false positive, but just removing all the =default'ed SMFs makes it go away, too. Amends 0dba3f6b713a657eb3bf2037face72d16253eb92. Pick-to: 6.7 Change-Id: Ib641d4eed9e214b41c143b60494e82790da6fda8 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: MÃ¥rten Nordheim <marten.nordheim@qt.io>
Diffstat (limited to 'src/network/access')
-rw-r--r--src/network/access/qhttp2connection_p.h6
1 files changed, 1 insertions, 5 deletions
diff --git a/src/network/access/qhttp2connection_p.h b/src/network/access/qhttp2connection_p.h
index 8e6bc52fc0..7ca303f0a8 100644
--- a/src/network/access/qhttp2connection_p.h
+++ b/src/network/access/qhttp2connection_p.h
@@ -40,15 +40,11 @@ class QH2Expected
{
static_assert(!std::is_same_v<T, Err>, "T and Err must be different types");
public:
+ // Rule Of Zero applies
QH2Expected(T &&value) : m_data(std::move(value)) { }
QH2Expected(const T &value) : m_data(value) { }
QH2Expected(Err &&error) : m_data(std::move(error)) { }
QH2Expected(const Err &error) : m_data(error) { }
- QH2Expected(const QH2Expected &) = default;
- QH2Expected(QH2Expected &&) = default;
- QH2Expected &operator=(const QH2Expected &) = default;
- QH2Expected &operator=(QH2Expected &&) = default;
- ~QH2Expected() = default;
QH2Expected &operator=(T &&value)
{