summaryrefslogtreecommitdiffstats
path: root/src/network/kernel
diff options
context:
space:
mode:
authorMårten Nordheim <marten.nordheim@qt.io>2020-09-10 16:30:36 +0200
committerMårten Nordheim <marten.nordheim@qt.io>2020-09-11 11:30:57 +0200
commit5a47939d5c07a968f27562a3ebc800fcc2b225bc (patch)
treea7cf1c3aef4d47a164230fda9e7d9e61505a5db7 /src/network/kernel
parent7dd99cd4885479feb7e09c55ab118c5ffb5b8476 (diff)
tst_QNetworkReply: Avoid race in ioGetFromHttpWithAuth
Our authentication code is race-y by design: 1. When two requests are fired off and queued at the same time in the same QHttpNetworkConnection then if one of them encounters "authentication required" then it will copy whatever credentials it got to all the other channels in the connection. This is likely what the first part of the test is testing. 2. If a later request is fired off and it includes credentials in the url then the newly included credentials should be used instead of the cached ones. The race here can occurr when one socket either takes too long to connect or the connected signal is not received early enough. Then the first socket is used for both requests and then we can hit case #2 when the url contains credentials. Pick-to: 5.15 Change-Id: I646a5378d8c1256b2de98b51912953df29f68cb2 Reviewed-by: Timur Pocheptsov <timur.pocheptsov@qt.io>
Diffstat (limited to 'src/network/kernel')
0 files changed, 0 insertions, 0 deletions