Don't use QByteArrayLiteral in comparisons

For const char*s, operator== is overloaded, so comparing to a (C) string
literal is efficient, since qstrcmp doesn't require the length of the
strings to compare.

OTOH, QByteArrayLiteral, when not using RVO, litters the code with
QByteArray dtor calls, which are not inline. Worse, absent lambdas,
it even allocates memory.

So, just compare with a (C) string literal instead.

Change-Id: Id3bfdc89558ba51911f6317a7a73c287f96e6f24
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>

1 files changed, 4 insertions, 4 deletions

diff --git a/src/network/ssl/qsslcertificate_qt.cpp b/src/network/ssl/qsslcertificate_qt.cpp
index 8019416aba..16df4a8f73 100644
--- a/src/network/ssl/qsslcertificate_qt.cpp
+++ b/src/network/ssl/qsslcertificate_qt.cpp
@@ -444,7 +444,7 @@ bool QSslCertificatePrivate::parseExtension(const QByteArray &data, QSslCertific
     QAsn1Element val;
     bool supported = true;
     QVariant value;
-    if (oid == QByteArrayLiteral("1.3.6.1.5.5.7.1.1")) {
+    if (oid == "1.3.6.1.5.5.7.1.1") {
         // authorityInfoAccess
         if (!val.read(valElem.value()) || val.type() != QAsn1Element::SequenceType)
             return false;
@@ -463,12 +463,12 @@ bool QSslCertificatePrivate::parseExtension(const QByteArray &data, QSslCertific
             }
         }
         value = result;
-    } else if (oid == QByteArrayLiteral("2.5.29.14")) {
+    } else if (oid == "2.5.29.14") {
         // subjectKeyIdentifier
         if (!val.read(valElem.value()) || val.type() != QAsn1Element::OctetStringType)
             return false;
         value = colonSeparatedHex(val.value()).toUpper();
-    } else if (oid == QByteArrayLiteral("2.5.29.19")) {
+    } else if (oid == "2.5.29.19") {
         // basicConstraints
         if (!val.read(valElem.value()) || val.type() != QAsn1Element::SequenceType)
             return false;
@@ -488,7 +488,7 @@ bool QSslCertificatePrivate::parseExtension(const QByteArray &data, QSslCertific
                 return false;
         }
         value = result;
-    } else if (oid == QByteArrayLiteral("2.5.29.35")) {
+    } else if (oid == "2.5.29.35") {
         // authorityKeyIdentifier
         if (!val.read(valElem.value()) || val.type() != QAsn1Element::SequenceType)
             return false;