diff options
author | Markus Goetz <Markus.Goetz@nokia.com> | 2011-04-13 14:16:15 +0200 |
---|---|---|
committer | Markus Goetz <Markus.Goetz@nokia.com> | 2011-05-03 16:47:05 +0200 |
commit | 718657d8b24ebd8f9004f41e79e6bd79c385b316 (patch) | |
tree | 793aa51cdfaa5810e208519732c06b75a0efbc07 /src/network | |
parent | ea4df8586e16efd82eb3ae5b71857c950cbb717f (diff) |
QNAM HTTP: Comments
Diffstat (limited to 'src/network')
-rw-r--r-- | src/network/access/qnetworkreplyhttpimpl.cpp | 18 |
1 files changed, 7 insertions, 11 deletions
diff --git a/src/network/access/qnetworkreplyhttpimpl.cpp b/src/network/access/qnetworkreplyhttpimpl.cpp index 5034176a3f..7e6f2d4b5e 100644 --- a/src/network/access/qnetworkreplyhttpimpl.cpp +++ b/src/network/access/qnetworkreplyhttpimpl.cpp @@ -244,7 +244,7 @@ QNetworkReplyHttpImpl::QNetworkReplyHttpImpl(QNetworkAccessManager* const manage QNetworkReplyHttpImpl::~QNetworkReplyHttpImpl() { - // FIXME? + // Most work is done in private destructor } void QNetworkReplyHttpImpl::close() @@ -264,35 +264,31 @@ void QNetworkReplyHttpImpl::abort() qint64 QNetworkReplyHttpImpl::bytesAvailable() const { Q_D(const QNetworkReplyHttpImpl); - qDebug() << "QNetworkReplyHttpImpl::bytesAvailable()"; - // FIXME cache device + // if we load from cache device if (d->cacheLoadDevice) { return QNetworkReply::bytesAvailable() + d->cacheLoadDevice->bytesAvailable() + d->downloadMultiBuffer.byteAmount(); } - // FIXME 0-copy buffer + // zerocopy buffer if (d->downloadZerocopyBuffer) { return QNetworkReply::bytesAvailable() + d->downloadBufferCurrentSize - d->downloadBufferReadPosition; } - // FIXME normal buffer - qDebug() << "QNetworkReplyHttpImpl::bytesAvailable() ==" << QNetworkReply::bytesAvailable() + d->downloadMultiBuffer.byteAmount(); + // normal buffer return QNetworkReply::bytesAvailable() + d->downloadMultiBuffer.byteAmount(); - - // FIXME } bool QNetworkReplyHttpImpl::isSequential () const { - // FIXME Maybe not for cache or 0-copy buffer + // FIXME In the cache of a cached load or the zero-copy buffer we could actually be non-sequential. + // FIXME however this requires us to implement stuff like seek() too. return true; } qint64 QNetworkReplyHttpImpl::size() const { - Q_D(const QNetworkReplyHttpImpl); - //return -1; + // FIXME At some point, this could return a proper value, e.g. if we're non-sequential. return QNetworkReply::size(); } |